From 9e111b9e7a07582f93896c840c1991a9b95145c7 Mon Sep 17 00:00:00 2001 From: BarbyBard Date: Mon, 6 Oct 2025 16:49:28 +0200 Subject: [PATCH 1/2] feat(log) specify origin destination pair for which direct routing failed --- java-r5rcore/src/org/ipea/r5r/Planner/TripPlanner.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/java-r5rcore/src/org/ipea/r5r/Planner/TripPlanner.java b/java-r5rcore/src/org/ipea/r5r/Planner/TripPlanner.java index 52f13a89..ee978469 100644 --- a/java-r5rcore/src/org/ipea/r5r/Planner/TripPlanner.java +++ b/java-r5rcore/src/org/ipea/r5r/Planner/TripPlanner.java @@ -148,18 +148,18 @@ private void findDirectPaths(ProfileRequest request, Map trips) { if(streetRouter.setOrigin(request.fromLat, request.fromLon)) { if(!streetRouter.setDestination(request.toLat, request.toLon)) { - LOG.warn("Direct mode {} destination wasn't found!", mode); + LOG.warn("Direct mode {} from {} to {} wasn't found! Problem at destination.", mode, fromId, toId); continue; } streetRouter.route(); StreetRouter.State lastState = streetRouter.getState(streetRouter.getDestinationSplit()); if (lastState == null) { - LOG.warn("Direct mode {} last state wasn't found", mode); + LOG.warn("Direct mode {} from {} to {}! Last state wasn't found.", mode, fromId, toId); continue; } streetPath = new StreetPath(lastState, transportNetwork, false); } else { - LOG.warn("Direct mode {} origin wasn't found!", mode); + LOG.warn("Direct mode {} from {} to {} wasn't found! Problem at origin.", mode, fromId, toId); continue; } @@ -199,7 +199,7 @@ private HashMap findAccessPaths(ProfileRequest request) { //Searching for access paths accessRouter.put(mode, streetRouter); } else { - LOG.warn("MODE:{}, Edge near the origin coordinate wasn't found. Routing didn't start!", mode); + LOG.warn("MODE:{}, Edge near the origin coordinate {} wasn't found. Routing didn't start!", mode, fromId); } } @@ -231,7 +231,7 @@ private Map findEgressPaths(ProfileRequest request) { LOG.info("Added {} egress stops for mode {}",stops.size(), mode); } else { - LOG.warn("MODE:{}, Edge near the origin coordinate wasn't found. Routing didn't start!", mode); + LOG.warn("MODE:{}, Edge near the origin coordinate {} wasn't found. Routing didn't start!", mode, fromId); } } From 3287e748015a780de834bf445ce9255ecea0f39d Mon Sep 17 00:00:00 2001 From: BarbyBard Date: Mon, 6 Oct 2025 18:26:19 +0200 Subject: [PATCH 2/2] fix(CI) update link to cran repo github actions recently switched from ubuntu 20 to ubuntu 24. It seems that r-lib hasn't updated the link to cran yet --- .github/workflows/java-r5rcore-build.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/java-r5rcore-build.yaml b/.github/workflows/java-r5rcore-build.yaml index f284a11b..1fe4fea8 100644 --- a/.github/workflows/java-r5rcore-build.yaml +++ b/.github/workflows/java-r5rcore-build.yaml @@ -25,7 +25,7 @@ jobs: - name: Install R packages run: | - install.packages(c('devtools', 'remotes')) + install.packages(c('devtools', 'remotes'), repos = "https://cloud.r-project.org") remotes::install_deps(dependencies = TRUE) shell: Rscript {0} working-directory: r-package