Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow class component to be referred to in JSX by the class object #2738

Closed
wants to merge 1 commit into from

Conversation

truongsinh
Copy link

Allow class component to be referred to in JSX by the class object, instead of tag name. E.g:

return <HelloWord />

Slack discussion: https://stencil-worldwide.slack.com/archives/C79EANFL7/p1604929720060900

@scabana
Copy link

scabana commented Feb 11, 2021

Got a feeling that the json doc will be missing stuff for fields:

dependents: string[];
dependencies: string[];
dependencyGraph: JsonDocsDependencyGraph;

@truongsinh truongsinh requested a review from a team October 6, 2021 16:35
@truongsinh truongsinh requested a review from a team as a code owner May 13, 2024 16:20
@christian-bromann
Copy link
Member

I looked into this PR and try to apply it on the current code base. While it actually allows to do what it claims I don't see an advantage of it right now as the user would loose all type safety using the class component instead of the tag name. There would be more to add for this to happen. Hence we will close it but make sure to add a note to our roadmap to see whether we want/can make this possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants