fix(android): preserve file chooser callback across activity recreation #8275
+92
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ionic-team#8246 When the Android system destroys and recreates the Activity while a file picker is open (due to backgrounding or memory pressure), the ValueCallback reference is lost, causing file uploads to fail silently. This fix stores the file chooser callbacks in static variables so they survive activity recreation. When the activity result is received: - If the instance callback exists, it's used normally - If the instance callback is null, the static pending callback is used Changes: - Added static variables to store pending file path callback, image URI, and file chooser type - Added FileChooserType enum to track which picker was opened - Added handlePendingFileChooserResult() to handle results when activity was recreated - Added clearPendingFileChooserState() to clean up static state - Updated showImageCapturePicker(), showVideoCapturePicker(), and showFilePicker() to store callbacks before launching
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 5, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 6, 2025
riderx
pushed a commit
to Cap-go/capacitor-plus
that referenced
this pull request
Dec 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8246
Description
When the Android system destroys and recreates the Activity while a file picker is open (due to backgrounding or memory pressure), the
ValueCallbackreference is lost, causing file uploads to fail silently.This fix stores the file chooser callbacks in static variables so they survive activity recreation. When the activity result is received:
Changes
FileChooserTypeenum to track which picker was opened