[fix]: Windows: Fix restart.ts to make it compatible with current Node.js (#2850)

* Windows: Fix restart.ts to make it compatible with current Node.js versions

* formatting and use of execAsync

* Fix powershell command

* simplify regex

---------

Co-authored-by: foxriver76 <[email protected]>

Author: Gaspode69

packages/controller/src/lib/restart.ts

@@ -1,6 +1,6 @@
 import { spawn } from 'node:child_process';
 import os from 'node:os';
-import { getRootDir } from '@iobroker/js-controller-common-db/tools';
+import { execAsync, getRootDir } from '@iobroker/js-controller-common-db/tools';
 import path from 'node:path';
 import url from 'node:url';
 
@@ -9,25 +9,45 @@ import url from 'node:url';
  *
  * @param callback callback to execute after restart is triggered
  */
-export default function restart(callback?: () => void): void {
+export default async function restart(callback?: () => void): Promise<void> {
     let cmd;
     let args;
     if (os.platform() === 'win32') {
-        // On Windows, we execute the controller entry point directly
-        cmd = path.join(getRootDir(), 'iob.bat');
-        args = ['restart'];
+        // On Windows, we use powershell to restart the service, because execution of bat files is no more possible
+        const envPath = path.join(getRootDir(), '.env').replaceAll('\\', '\\\\');
+        cmd = `powershell -Command "$envPath = \\"${envPath}\\";
+        $iobServiceName = \\"ioBroker\\";
+        if (Test-Path $envPath) {
+          foreach ($line in Get-Content $envPath) {
+            $line = $line.Trim();
+            if ($line -match \\"^\\s*iobservicename\\s*=\\s*(.+)\\s*$\\") {
+                $iobServiceName = $matches[1].Trim(); break;
+            }
+          }
+        }
+        Write-Output \\"Restarting service $iobServiceName.exe\\";Restart-Service \\"$iobServiceName.exe\\" -Force"`;
+
+        // Remove line breaks, because the powershell command will fail otherwise
+        cmd = cmd.replace(/[\r\n]+/gm, ' ');
+
+        try {
+            await execAsync(cmd);
+        } catch (e) {
+            console.error(`Restart failed: ${e.message}`);
+        }
     } else {
         // Unix has a global ioBroker binary that delegates to the init system
         // We need to call that, so we don't have two instances of ioBroker running
         cmd = 'iobroker';
         args = ['restart'];
+
+        const child = spawn(cmd, args, {
+            detached: true,
+            stdio: ['ignore', 'ignore', 'ignore'],
+            windowsHide: true
+        });
+        child.unref();
     }
-    const child = spawn(cmd, args, {
-        detached: true,
-        stdio: ['ignore', 'ignore', 'ignore'],
-        windowsHide: true
-    });
-    child.unref();
     if (typeof callback === 'function') {
         setTimeout(() => callback(), 500);
     } else {