Fix adminUI and related object fields not being replaced during adapter upload (#3096)

* Initial plan

* Fix adminUI and related fields merging during adapter upload

- Add replaceAttributes list to extendCommon method
- Include adminUI, adminTab, and adminColumns in replacement list
- These fields are now completely replaced instead of merged
- Preserves backward compatibility for other object merging
- Fixes issue where old adminUI configs persisted after removal

Co-authored-by: Apollon77 <[email protected]>

* Add changelog entry for adminUI fix

Co-authored-by: Apollon77 <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: Apollon77 <[email protected]>
Co-authored-by: Ingo Fischer <[email protected]>
Co-authored-by: Bluefox <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -5,6 +5,7 @@
 -->
 
 ## __WORK IN PROGRESS__
+* (@copilot) Fixed adminUI, adminTab, and adminColumns configurations being incorrectly preserved during adapter uploads
 * (@foxriver76) Added objects warn limit per instance
 * (@Apollon77) Allows only numbers for `ts` and `lc` fields in state when provided for setState
 * (@GermanBluefox) Added typing for `visIconSets` in `io-package.json`(for vis-2 SVG icon sets)

packages/cli/src/lib/setup/setupUpload.ts

@@ -670,13 +670,20 @@ export class Upload {
                 'tier',
             ];
 
+            // Object attributes that should be completely replaced, not merged
+            const replaceAttributes = ['adminUI', 'adminTab', 'adminColumns'];
+
             for (const [attr, attrData] of Object.entries(additional)) {
                 // preserve these attributes, except, they were undefined before and preserve titleLang if current titleLang is of type string (changed by user)
                 if (preserveAttributes.includes(attr) || (attr === 'titleLang' && typeof target[attr] === 'string')) {
                     if (target[attr] === undefined) {
                         target[attr] = attrData;
                     }
-                } else if (typeof attrData !== 'object' || attrData instanceof Array) {
+                } else if (
+                    typeof attrData !== 'object' ||
+                    attrData instanceof Array ||
+                    replaceAttributes.includes(attr)
+                ) {
                     try {
                         target[attr] = attrData;