Skip to content

Commit f5d266c

Browse files
committed
slashing+registry_fixed
0 parents  commit f5d266c

63 files changed

Lines changed: 14229 additions & 0 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/registry.yml

Lines changed: 66 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,66 @@
1+
name: CI
2+
3+
on:
4+
push:
5+
pull_request:
6+
workflow_dispatch:
7+
8+
env:
9+
FOUNDRY_PROFILE: ci
10+
11+
jobs:
12+
codespell:
13+
name: Check for spelling errors
14+
runs-on: ubuntu-latest
15+
16+
steps:
17+
- name: Checkout
18+
uses: actions/checkout@v4
19+
with:
20+
fetch-depth: 0
21+
22+
- name: Codespell
23+
uses: codespell-project/[email protected]
24+
with:
25+
check_hidden: true
26+
check_filenames: true
27+
tests:
28+
runs-on: ubuntu-latest
29+
environment: CI
30+
steps:
31+
- name: Cancel previous actions
32+
uses: styfle/[email protected]
33+
34+
- uses: actions/checkout@v4
35+
with:
36+
submodules: recursive
37+
38+
- name: Print branch name
39+
run: echo running on branch ${GITHUB_HEAD_REF:-$GITHUB_REF_NAME}
40+
41+
- name: Install Foundry
42+
uses: foundry-rs/foundry-toolchain@v1
43+
with:
44+
version: v0.3.0
45+
46+
- name: Show Forge version
47+
run: |
48+
forge --version
49+
50+
- name: Run Forge fmt
51+
run: |
52+
forge fmt --check
53+
id: fmt
54+
55+
- name: Run Forge build
56+
run: |
57+
forge build --sizes
58+
id: build
59+
60+
- name: Run Forge tests
61+
run: |
62+
forge test -vvv
63+
id: test
64+
env:
65+
ETH_RPC_URL: ${{ secrets.ETH_RPC_URL }}
66+
HOLESKY_RPC_URL: ${{ secrets.HOLESKY_RPC_URL }}

.gitignore

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Compiler files
2+
cache/
3+
out/
4+
5+
# Ignores development broadcast logs
6+
!/broadcast
7+
/broadcast/*/31337/
8+
/broadcast/**/dry-run/
9+
/lib/
10+
.env
11+
.cursorrules

.gitmodules

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
[submodule "lib/forge-std"]
2+
path = lib/forge-std
3+
url = https://github.com/foundry-rs/forge-std
4+
[submodule "lib/openzeppelin-contracts"]
5+
path = lib/openzeppelin-contracts
6+
url = https://github.com/OpenZeppelin/openzeppelin-contracts
7+
[submodule "lib/core"]
8+
path = lib/core
9+
url = https://github.com/symbioticfi/core.git
10+
[submodule "lib/eigenlayer-contracts"]
11+
path = lib/eigenlayer-contracts
12+
url = https://github.com/Layr-Labs/eigenlayer-contracts.git
13+
[submodule "lib/eigenlayer-middleware"]
14+
path = lib/eigenlayer-middleware
15+
url = https://github.com/Layr-Labs/eigenlayer-middleware.git
16+
[submodule "lib/karak"]
17+
path = lib/karak
18+
url = https://github.com/code-423n4/2024-07-karak.git

LICENSE-APACHE

Lines changed: 201 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,201 @@
1+
Apache License
2+
Version 2.0, January 2004
3+
http://www.apache.org/licenses/
4+
5+
TERMS AND CONDITIONS FOR USE, REPRODUCTION, AND DISTRIBUTION
6+
7+
1. Definitions.
8+
9+
"License" shall mean the terms and conditions for use, reproduction,
10+
and distribution as defined by Sections 1 through 9 of this document.
11+
12+
"Licensor" shall mean the copyright owner or entity authorized by
13+
the copyright owner that is granting the License.
14+
15+
"Legal Entity" shall mean the union of the acting entity and all
16+
other entities that control, are controlled by, or are under common
17+
control with that entity. For the purposes of this definition,
18+
"control" means (i) the power, direct or indirect, to cause the
19+
direction or management of such entity, whether by contract or
20+
otherwise, or (ii) ownership of fifty percent (50%) or more of the
21+
outstanding shares, or (iii) beneficial ownership of such entity.
22+
23+
"You" (or "Your") shall mean an individual or Legal Entity
24+
exercising permissions granted by this License.
25+
26+
"Source" form shall mean the preferred form for making modifications,
27+
including but not limited to software source code, documentation
28+
source, and configuration files.
29+
30+
"Object" form shall mean any form resulting from mechanical
31+
transformation or translation of a Source form, including but
32+
not limited to compiled object code, generated documentation,
33+
and conversions to other media types.
34+
35+
"Work" shall mean the work of authorship, whether in Source or
36+
Object form, made available under the License, as indicated by a
37+
copyright notice that is included in or attached to the work
38+
(an example is provided in the Appendix below).
39+
40+
"Derivative Works" shall mean any work, whether in Source or Object
41+
form, that is based on (or derived from) the Work and for which the
42+
editorial revisions, annotations, elaborations, or other modifications
43+
represent, as a whole, an original work of authorship. For the purposes
44+
of this License, Derivative Works shall not include works that remain
45+
separable from, or merely link (or bind by name) to the interfaces of,
46+
the Work and Derivative Works thereof.
47+
48+
"Contribution" shall mean any work of authorship, including
49+
the original version of the Work and any modifications or additions
50+
to that Work or Derivative Works thereof, that is intentionally
51+
submitted to Licensor for inclusion in the Work by the copyright owner
52+
or by an individual or Legal Entity authorized to submit on behalf of
53+
the copyright owner. For the purposes of this definition, "submitted"
54+
means any form of electronic, verbal, or written communication sent
55+
to the Licensor or its representatives, including but not limited to
56+
communication on electronic mailing lists, source code control systems,
57+
and issue tracking systems that are managed by, or on behalf of, the
58+
Licensor for the purpose of discussing and improving the Work, but
59+
excluding communication that is conspicuously marked or otherwise
60+
designated in writing by the copyright owner as "Not a Contribution."
61+
62+
"Contributor" shall mean Licensor and any individual or Legal Entity
63+
on behalf of whom a Contribution has been received by Licensor and
64+
subsequently incorporated within the Work.
65+
66+
2. Grant of Copyright License. Subject to the terms and conditions of
67+
this License, each Contributor hereby grants to You a perpetual,
68+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
69+
copyright license to reproduce, prepare Derivative Works of,
70+
publicly display, publicly perform, sublicense, and distribute the
71+
Work and such Derivative Works in Source or Object form.
72+
73+
3. Grant of Patent License. Subject to the terms and conditions of
74+
this License, each Contributor hereby grants to You a perpetual,
75+
worldwide, non-exclusive, no-charge, royalty-free, irrevocable
76+
(except as stated in this section) patent license to make, have made,
77+
use, offer to sell, sell, import, and otherwise transfer the Work,
78+
where such license applies only to those patent claims licensable
79+
by such Contributor that are necessarily infringed by their
80+
Contribution(s) alone or by combination of their Contribution(s)
81+
with the Work to which such Contribution(s) was submitted. If You
82+
institute patent litigation against any entity (including a
83+
cross-claim or counterclaim in a lawsuit) alleging that the Work
84+
or a Contribution incorporated within the Work constitutes direct
85+
or contributory patent infringement, then any patent licenses
86+
granted to You under this License for that Work shall terminate
87+
as of the date such litigation is filed.
88+
89+
4. Redistribution. You may reproduce and distribute copies of the
90+
Work or Derivative Works thereof in any medium, with or without
91+
modifications, and in Source or Object form, provided that You
92+
meet the following conditions:
93+
94+
(a) You must give any other recipients of the Work or
95+
Derivative Works a copy of this License; and
96+
97+
(b) You must cause any modified files to carry prominent notices
98+
stating that You changed the files; and
99+
100+
(c) You must retain, in the Source form of any Derivative Works
101+
that You distribute, all copyright, patent, trademark, and
102+
attribution notices from the Source form of the Work,
103+
excluding those notices that do not pertain to any part of
104+
the Derivative Works; and
105+
106+
(d) If the Work includes a "NOTICE" text file as part of its
107+
distribution, then any Derivative Works that You distribute must
108+
include a readable copy of the attribution notices contained
109+
within such NOTICE file, excluding those notices that do not
110+
pertain to any part of the Derivative Works, in at least one
111+
of the following places: within a NOTICE text file distributed
112+
as part of the Derivative Works; within the Source form or
113+
documentation, if provided along with the Derivative Works; or,
114+
within a display generated by the Derivative Works, if and
115+
wherever such third-party notices normally appear. The contents
116+
of the NOTICE file are for informational purposes only and
117+
do not modify the License. You may add Your own attribution
118+
notices within Derivative Works that You distribute, alongside
119+
or as an addendum to the NOTICE text from the Work, provided
120+
that such additional attribution notices cannot be construed
121+
as modifying the License.
122+
123+
You may add Your own copyright statement to Your modifications and
124+
may provide additional or different license terms and conditions
125+
for use, reproduction, or distribution of Your modifications, or
126+
for any such Derivative Works as a whole, provided Your use,
127+
reproduction, and distribution of the Work otherwise complies with
128+
the conditions stated in this License.
129+
130+
5. Submission of Contributions. Unless You explicitly state otherwise,
131+
any Contribution intentionally submitted for inclusion in the Work
132+
by You to the Licensor shall be under the terms and conditions of
133+
this License, without any additional terms or conditions.
134+
Notwithstanding the above, nothing herein shall supersede or modify
135+
the terms of any separate license agreement you may have executed
136+
with Licensor regarding such Contributions.
137+
138+
6. Trademarks. This License does not grant permission to use the trade
139+
names, trademarks, service marks, or product names of the Licensor,
140+
except as required for reasonable and customary use in describing the
141+
origin of the Work and reproducing the content of the NOTICE file.
142+
143+
7. Disclaimer of Warranty. Unless required by applicable law or
144+
agreed to in writing, Licensor provides the Work (and each
145+
Contributor provides its Contributions) on an "AS IS" BASIS,
146+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
147+
implied, including, without limitation, any warranties or conditions
148+
of TITLE, NON-INFRINGEMENT, MERCHANTABILITY, or FITNESS FOR A
149+
PARTICULAR PURPOSE. You are solely responsible for determining the
150+
appropriateness of using or redistributing the Work and assume any
151+
risks associated with Your exercise of permissions under this License.
152+
153+
8. Limitation of Liability. In no event and under no legal theory,
154+
whether in tort (including negligence), contract, or otherwise,
155+
unless required by applicable law (such as deliberate and grossly
156+
negligent acts) or agreed to in writing, shall any Contributor be
157+
liable to You for damages, including any direct, indirect, special,
158+
incidental, or consequential damages of any character arising as a
159+
result of this License or out of the use or inability to use the
160+
Work (including but not limited to damages for loss of goodwill,
161+
work stoppage, computer failure or malfunction, or any and all
162+
other commercial damages or losses), even if such Contributor
163+
has been advised of the possibility of such damages.
164+
165+
9. Accepting Warranty or Additional Liability. While redistributing
166+
the Work or Derivative Works thereof, You may choose to offer,
167+
and charge a fee for, acceptance of support, warranty, indemnity,
168+
or other liability obligations and/or rights consistent with this
169+
License. However, in accepting such obligations, You may act only
170+
on Your own behalf and on Your sole responsibility, not on behalf
171+
of any other Contributor, and only if You agree to indemnify,
172+
defend, and hold each Contributor harmless for any liability
173+
incurred by, or claims asserted against, such Contributor by reason
174+
of your accepting any such warranty or additional liability.
175+
176+
END OF TERMS AND CONDITIONS
177+
178+
APPENDIX: How to apply the Apache License to your work.
179+
180+
To apply the Apache License to your work, attach the following
181+
boilerplate notice, with the fields enclosed by brackets "[]"
182+
replaced with your own identifying information. (Don't include
183+
the brackets!) The text should be enclosed in the appropriate
184+
comment syntax for the file format. We also recommend that a
185+
file or class name and description of purpose be included on the
186+
same "printed page" as the copyright notice for easier
187+
identification within third-party archives.
188+
189+
Copyright 2025 ethereum-commitments
190+
191+
Licensed under the Apache License, Version 2.0 (the "License");
192+
you may not use this file except in compliance with the License.
193+
You may obtain a copy of the License at
194+
195+
http://www.apache.org/licenses/LICENSE-2.0
196+
197+
Unless required by applicable law or agreed to in writing, software
198+
distributed under the License is distributed on an "AS IS" BASIS,
199+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
200+
See the License for the specific language governing permissions and
201+
limitations under the License.

LICENSE-MIT

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
MIT License
2+
3+
Copyright (c) 2024 ethereum-commitments
4+
5+
Permission is hereby granted, free of charge, to any person obtaining a copy
6+
of this software and associated documentation files (the "Software"), to deal
7+
in the Software without restriction, including without limitation the rights
8+
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
9+
copies of the Software, and to permit persons to whom the Software is
10+
furnished to do so, subject to the following conditions:
11+
12+
The above copyright notice and this permission notice shall be included in all
13+
copies or substantial portions of the Software.
14+
15+
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16+
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17+
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18+
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19+
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20+
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21+
SOFTWARE.

README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
All Interstate changes are in the README.md and the `/slasher` folder which has been renamed from `/example` all other files are the same as source: https://github.com/eth-fabric/urc/blob/main/src/Registry.sol
2+
3+
Notes for auditors: We would additionally prefer to have MIN_COLLATERAL Field here https://github.com/interstate-labs/urc/blob/main/src/Registry.sol#L21 set to 0 to allow operators to default to restaking only if they wish.
4+
5+
These contracts allow a validator to register collateral and enable proposer commitments, a subset of Interstate's functionality. Native Ether or a restaking protocol can be used as collateral. We support Karak, Eigenlayer, and Symbiotic

docs/decisions.md

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
2+
## Don't save validator public keys on-chain
3+
4+
**Pros**:
5+
- Significantly reduces storage costs and barriers to entry
6+
- Keys can be stored in an extension contract
7+
8+
**Cons**:
9+
- Harder to verify directly on-chain (requires submitting merkle proof)
10+
11+
**Current Implementation**:
12+
13+
Instead of saving validator public keys on-chain, the `register()` function merkleizes the `Registrations` and saves the root hash to the `commitments` mapping. This allows anyone verify whether a validator is opted-in and their collateral without storing the public key on-chain. This optimization reduces storage costs from `48 bytes` per validator to a constant `32 bytes` per batch of validators.
14+
15+
16+
## Batching Operators
17+
**Pros**:
18+
- Reduces gas costs
19+
- Collateral is shared across all validators in the batch (efficient for big 🐋)
20+
21+
**Cons**:
22+
- Collateral is shared across all validators in the batch (inefficient for small 🐟)
23+
24+
**Current Implementation**:
25+
26+
The current implementation batches `N` validators per operator into a single `register()` call. This reduces gas costs by minimizing function calls and storage. The implication is that the Ether collateral is shared across all validators in the batch. However, since block proposals must happen sequentially, the collateral only needs to apply to a single validator at a time.
27+
28+
29+
## Don't verify BLS signatures at registration time
30+
31+
**Pros**:
32+
- Reduces gas costs
33+
34+
**Cons**:
35+
- Valid registrations must wait for the fraud proof window to pass
36+
- Introduces a minimum collateral requirement
37+
38+
**Current Implementation**:
39+
40+
Even post-Pectra upgrade, BLS precompiles are still expensive and would need to be called per validator. To avoid this, the current implementation optimistically accepts BLS signatures at registration time. Before the `FRAUD_PROOF_WINDOW` elapses, anyone can pay the gas to run the BLS signature verification on-chain and claim `MIN_COLLATERAL` from the operator as an incentive.
41+
42+
## Don't use bytecode to slash
43+
To opt-in to preconfs, operators will commit to slashing conditions by signing off-chain `DelegationMessages`. To support general slashing logic, the initial idea was to have operators commit to a bytecode hash. Upon slashing, the URC would deploy and execute the corresponding bytecode. The return value of the function call is the amount of GWEI to be slashed from the operator's collateral.
44+
45+
**Pros of bytecode**:
46+
- Elegant design
47+
- Universal
48+
49+
**Cons of bytecode**:
50+
- Executing bytecode requires first deploying it which eats into the gas limit or using lower-level languages like [Huff](https://docs.huff.sh/get-started/overview/)
51+
- The approach cannot be used for stateful slashing logic, e.g., fraud proofs
52+
- Bytecode is not easily verified/readable
53+
54+
**Current Implementation**:
55+
56+
Over several discussions, we decided replace bytecode commitments with slashing contract commitments. The bytecode approach supports universal slashing logic by encoding it directly as EVM logic or by deploying ZK-verification logic. However, the main motivator against using bytecode is that it does not allow for stateful slashing logic. For example, any protocol wishing to implement fraud proofs for their slashing logic would be incompatible with the bytecode approach. This is because the fraud proof game would need to be played over multiple rounds, implying it saves intermediate state.
57+
58+
In the current implementation, proposers commit to an arbitrary contract address which is expected to support a general purpose interface: `slash(bytes inputs)`. Similarly to the bytecode approach, the return value of the `slash(bytes inputs)` function is the amount of GWEI to be slashed.
59+
60+
This approach has the following benefits:
61+
- Each `Slasher` contract only needs to be deployed once and can be verified on-chain.
62+
- Arbitrary stateful logic can be executed on the `Slasher`. (e.g., a fraud proof game is played ahead of time and then calling `slash(bytes inputs)` returns the slashing outcome)
63+
- Supports arbitrarily complex slashing logic, even existing restaking protocols
64+
- Can support the execution of arbitrary bytecode by deploying a dedicated `Slasher` contract

0 commit comments

Comments
 (0)