feat(backend): require wallet address prefix on tenant creation

Author: njlie

packages/backend/src/open_payments/wallet_address/errors.ts

@@ -4,7 +4,8 @@ export enum WalletAddressError {
   InvalidUrl = 'InvalidUrl',
   UnknownAsset = 'UnknownAsset',
   UnknownWalletAddress = 'UnknownWalletAddress',
-  DuplicateWalletAddress = 'DuplicateWalletAddress'
+  DuplicateWalletAddress = 'DuplicateWalletAddress',
+  UnknownTenant = 'UnknownTenant'
 }
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
@@ -17,7 +18,8 @@ export const errorToCode: {
   [WalletAddressError.InvalidUrl]: GraphQLErrorCode.BadUserInput,
   [WalletAddressError.UnknownAsset]: GraphQLErrorCode.BadUserInput,
   [WalletAddressError.UnknownWalletAddress]: GraphQLErrorCode.NotFound,
-  [WalletAddressError.DuplicateWalletAddress]: GraphQLErrorCode.Duplicate
+  [WalletAddressError.DuplicateWalletAddress]: GraphQLErrorCode.Duplicate,
+  [WalletAddressError.UnknownTenant]: GraphQLErrorCode.BadUserInput
 }
 
 export const errorToMessage: {
@@ -27,5 +29,6 @@ export const errorToMessage: {
   [WalletAddressError.UnknownAsset]: 'unknown asset',
   [WalletAddressError.UnknownWalletAddress]: 'unknown wallet address',
   [WalletAddressError.DuplicateWalletAddress]:
-    'Duplicate wallet address found with the same url'
+    'Duplicate wallet address found with the same url',
+  [WalletAddressError.UnknownTenant]: 'unknown tenant'
 }

packages/backend/src/open_payments/wallet_address/service.test.ts

@@ -93,57 +93,13 @@ describe('Open Payments Wallet Address Service', (): void => {
       }
     )
 
-    test.each`
-      isOperator | tenantSettingUrl
-      ${false}   | ${undefined}
-      ${true}    | ${undefined}
-      ${true}    | ${`https://alice.me/${uuid()}`}
-    `(
-      'operator - $isOperator with tenantSettingUrl - $tenantSettingUrl',
-      async ({ isOperator, tenantSettingUrl }): Promise<void> => {
-        const address = 'test'
-        const tempTenant = await createTenant(deps, {
-          walletAddressPrefix: tenantSettingUrl
-        })
-        const { id: tempAssetId } = await createAsset(deps, {
-          tenantId: tempTenant.id
-        })
-
-        let expected: string
-        if (tenantSettingUrl) {
-          expected = `${tenantSettingUrl}/${address}`
-        } else {
-          if (isOperator) {
-            expected = `https://op.example/${address}`
-          }
-        }
-
-        const created = await walletAddressService.create({
-          ...options,
-          address,
-          isOperator,
-          assetId: tempAssetId,
-          tenantId: tempTenant.id
-        })
-
-        if (isWalletAddressError(expected)) {
-          expect(created).toEqual(expected)
-        } else {
-          assert.ok(!isWalletAddressError(created))
-          expect(created.address).toEqual(expected)
-        }
-      }
-    )
-
-    test('should return error without tenant settings if caller is not an operator', async () => {
-      const tempTenant = await createTenant(deps)
-
+    test('should return error if unknown tenant', async () => {
       expect(
         await walletAddressService.create({
           ...options,
-          tenantId: tempTenant.id
+          tenantId: uuid()
         })
-      ).toEqual(WalletAddressError.WalletAddressPrefixNotFound)
+      ).toEqual(WalletAddressError.UnknownTenant)
     })
 
     test('should return InvalidUrl error if wallet address URL does not start with tenant wallet address URL', async (): Promise<void> => {