Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

interledger-ildcp API review for v1.0-rc #573

Closed
4 tasks done
gakonst opened this issue Dec 18, 2019 · 0 comments
Closed
4 tasks done

interledger-ildcp API review for v1.0-rc #573

gakonst opened this issue Dec 18, 2019 · 0 comments
Assignees
@gakonst
Labels
crate/interledger-ildcp docs v1.0 Issues which need to be handled for a v1.0 release

Comments

@gakonst
Copy link
Member

gakonst commented Dec 18, 2019 •
edited
Loading

interledger-ildcp public items marked with x are documented. Non-exported items are not taken into account. Follows format from #561.

Part of #557.

  • get_ildcp_info (fn)
  • IldcpService (struct)
    • handle_request should be documented
  • packet::IldcpRequest
    • Can we move the to_prepare implementation inside the From implementation?
  • packet::IldcpResponse
@gakonst gakonst mentioned this issue Jan 20, 2020
Closed
11 tasks
@gakonst gakonst self-assigned this Jan 20, 2020
@gakonst gakonst added v1.0 Issues which need to be handled for a v1.0 release docs labels Jan 20, 2020
@gakonst gakonst closed this as completed Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gakonst gakonst

Labels
crate/interledger-ildcp docs v1.0 Issues which need to be handled for a v1.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gakonst