Skip to content

Commit 8297c37

Browse files
authored
Merge pull request #82 from intergral/build_docs
fix(docs): make doc check fail on warnings
2 parents 78a8f92 + da10580 commit 8297c37

File tree

5 files changed

+22
-4
lines changed

5 files changed

+22
-4
lines changed

.github/workflows/on_release.yml

+10-2
Original file line numberDiff line numberDiff line change
@@ -36,14 +36,22 @@ jobs:
3636
- name: Build and Release
3737
run: mvn -s .ci-settings.xml clean deploy -DskipTests -P release-ossrh -B -U -pl agent,deep --also-make
3838

39-
- name: Upload binaries to release
39+
- name: Upload agent to release
4040
uses: svenstaro/upload-release-action@v2
4141
with:
42-
file: ./agent/target/deep-${VERSION}.jar
42+
file: ./agent/target/agent-${VERSION}.jar
4343
asset_name: Deep Agent
4444
tag: ${{ github.ref_name }}
4545
overwrite: true
4646

47+
- name: Upload lite agent to release
48+
uses: svenstaro/upload-release-action@v2
49+
with:
50+
file: ./agent/target/agent-${VERSION}-lite.jar
51+
asset_name: Deep Lite Agent
52+
tag: ${{ github.ref_name }}
53+
overwrite: true
54+
4755
JavaSite:
4856
runs-on: ubuntu-latest
4957
steps:

.github/workflows/update_docs.yml

-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ jobs:
3838
mergeBuilds:
3939
runs-on: ubuntu-latest
4040
needs:
41-
- JavaSite
4241
- mkdocs
4342
steps:
4443
- name: Download Mkdocs artifact

CHANGELOG.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
# 1.2.0 (xx/xx/2023)
1+
# main - Unreleased
2+
3+
4+
# 1.1.3 (15/12/2023)
25
- **[CHANGE]**: update: Update deep proto to 1.0.3 [#74](https://github.com/intergral/deep/pull/74) [@Umaaz](https://github.com/Umaaz)
36
- **[CHANGE]**: plugin: Change the plugins to use SPI to load [#77](https://github.com/intergral/deep/pull/77) [@Umaaz](https://github.com/Umaaz)
47
- **[FEATURE]**: metrics: Add support for metrics from tracepoints [#74](https://github.com/intergral/deep/pull/74) [@Umaaz](https://github.com/Umaaz)

agent/src/main/java/com/intergral/deep/agent/tracepoint/handler/FrameCollector.java

+5
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,12 @@ protected String getMethodName(final StackTraceElement stackTraceElement,
357357
* So if we cannot get a result from the {@link IEvaluator} then we return an error result.
358358
*
359359
* @param watch the watch expression to evaluate
360+
* @param source the source of the watch expression
360361
* @return a {@link IExpressionResult}
362+
*
363+
* @see WatchResult#LOG
364+
* @see WatchResult#METRIC
365+
* @see WatchResult#WATCH
361366
*/
362367
protected IExpressionResult evaluateWatchExpression(final String watch, final String source) {
363368
try {

pom.xml

+3
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,9 @@
204204
<goals>
205205
<goal>jar</goal>
206206
</goals>
207+
<configuration>
208+
<failOnWarnings>true</failOnWarnings>
209+
</configuration>
207210
</execution>
208211
</executions>
209212
</plugin>

0 commit comments

Comments
 (0)