From 54072af8a97a9ef8a4096dec6484c9b974f270c9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Filip=20Tron=C3=AD=C4=8Dek?= <filip.tronicek@seznam.cz>
Date: Sun, 5 Sep 2021 20:55:48 +0200
Subject: [PATCH] feat: add types and error handling

---
 components/ContributorList.tsx | 61 ++++++++++++++++++++++++----------
 1 file changed, 44 insertions(+), 17 deletions(-)

diff --git a/components/ContributorList.tsx b/components/ContributorList.tsx
index bd67069b..4bb83e34 100644
--- a/components/ContributorList.tsx
+++ b/components/ContributorList.tsx
@@ -11,38 +11,65 @@ import {
 
 import * as Linking from "expo-linking";
 import { Image } from "react-native-elements";
+import { Notifier, NotifierComponents } from "react-native-notifier";
 
 import { colors } from "../lib/vars";
 
 type contributorType = {
   login: string;
   type: "Bot" | "User" | "Organization";
+  avatar_url: string;
+  html_url: string;
 };
 
 const ContributorList = () => {
-  const [contributors, setContributors] = useState(["interclip"]);
+  const [contributors, setContributors] = useState<[contributorType]>([
+    {
+      login: "interclip",
+      type: "User",
+      avatar_url: "https://avatars.githubusercontent.com/u/87187104?v=4",
+      html_url: "https://github.com/interclip",
+    },
+  ]);
   const colorScheme = useColorScheme();
 
   // Fetch the contributors from the GitHub API
   useEffect(() => {
     fetch("https://api.github.com/repos/interclip/mobile/contributors")
-      .then((response) => response.json())
+      .then((response) => {
+        // Check for errors
+        if (!response.ok) {
+          Notifier.showNotification({
+            title: "Sheeesh",
+            description: `Encountered an error while fetching contributors: (${response.status})`,
+            Component: NotifierComponents.Alert,
+            componentProps: {
+              alertType: "error",
+            },
+          });
+          return [{ login: "interclip", type: "Bot" }];
+        }
+        return response.json();
+      })
       .then((responseJson) => {
         const exemptUsers = ["restyled-commits", "codacy-badger"];
-        const contributorLogins = responseJson
-          .filter(
-            (contributor: contributorType) =>
-              contributor.type !== "Bot" &&
-              !exemptUsers.includes(contributor.login)
-          )
-          .map((contributor: contributorType) => contributor.login);
+        const contributorLogins = responseJson.filter(
+          (contributor: contributorType) =>
+            contributor.type !== "Bot" &&
+            !exemptUsers.includes(contributor.login)
+        );
         setContributors(contributorLogins);
       })
       .catch((_error) => {
-        Alert.alert(
-          "Error",
-          "There was an error fetching the contributors. Please try again later."
-        );
+        Notifier.showNotification({
+          title: "Error",
+          description:
+            "There was an error fetching the contributors. Please try again later.",
+          Component: NotifierComponents.Alert,
+          componentProps: {
+            alertType: "error",
+          },
+        });
       });
   }, []);
 
@@ -61,15 +88,15 @@ const ContributorList = () => {
             colorScheme === "dark" ? colors.lightContent : colors.darkContent,
         }}
       >
-        Made by:{" "}
+        {contributors.length > 0 ? "Made by: " : ""}
       </Text>
       {contributors.map((contributor) => {
         return (
           <Image
-            key={contributor}
-            onPress={() => Linking.openURL(`https://github.com/${contributor}`)}
+            key={contributor.login}
+            onPress={() => Linking.openURL(contributor.html_url)}
             source={{
-              uri: `https://github.com/${contributor}.png`,
+              uri: contributor.avatar_url,
             }}
             style={{
               width: 35,