Skip to content

[SYCL][NFC] Fix a Coverity hit in device_image_impl ctor #20579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[SYCL][NFC] Fix a Coverity hit in device_image_impl ctor #20579

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c4cc88
[SYCL][NFC] Fix Coverity hit in device_image_impl ctor
sergey-semenov Nov 6, 2025
fbe39de
Switch to pass-by-value + move
sergey-semenov Nov 6, 2025
544a99d
Merge branch 'sycl' into coverityfix
sergey-semenov Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ class device_image_impl
updateSpecConstSymMap();
}

device_image_impl(const std::string &Src, context Context,
device_image_impl(const std::string &Src, const context &Context,
Copy link
Contributor

@aelovikov-intel aelovikov-intel Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert on the best practices, but I think std::move could be better on average:

device_image_impl obj(..., create_rval_context(), ...); // 1
device_image_impl obj(..., lval_context, ...);          // 2

For by-value param followed by a std::move we'd have two move-ctors (1) and copy-ctor + move-ctor (2).

For by-const-ref we'll have copy-ctor (1) and copy-ctor. Effectively, we remove one move-ctor (cheap) in either case and introduce a more expensive copy-ctor in (1).

That said, it's probably unlikely to matter in practice, so LGTM.

+ @vinser52 in case we need to update our "informal style guides".

Copy link
Contributor Author

@sergey-semenov sergey-semenov Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed it this way mostly to align with the rest of the constructors, but I do prefer pass-by-value then move as well. And, on closer inspection, we actually have a weird mix of the two in this file, so I'll update the PR to use that instead.

devices_range Devices, syclex::source_language Lang,
include_pairs_t &&IncludePairsVec, private_tag)
: MBinImage(Src), MContext(Context),
Expand Down
Loading