-
Notifications
You must be signed in to change notification settings - Fork 537
test: move language scanner tests to longtests #4322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
good first issue
Good for newcomers
Comments
Since I've flagged this as a good first issue, here's the standard tips: Short tips for new contributors:
Claiming issues:
|
muddi900
added a commit
to muddi900/cve-bin-tool
that referenced
this issue
Aug 9, 2024
9 tasks
terriko
added a commit
that referenced
this issue
Aug 15, 2024
* test: `test_language_package` is not skipped if LONG_TEST is disabled.[Issue #4322] * Fixed the liniting error. * changes to triage file * Updated the mark to handle all input params. --------- Co-authored-by: Terri Oda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In #4321 I've noted that our slowest tests are all instances of
test_language_package
.While we figure out the best way to improve performance for those, I do think it would be good right now to accept that those are long tests and move them accordingly so they only run if long tests are enabled. This should be doable by a beginner but it may take some reading to understand how pytest parameterization and skipping work.
Step by step instructions:
test/test_language_scanner.py
and look at the functiontest_language_package
test_language_package
to achieve the same effect and do it!black test/test_language_scanner.py
to make sure you're style compliant. It'll also let you know if there's a syntax errorpytest -k test_language_package
on your local machine. If you get a bunch ofsss
notes showing skipped tests, you did it! (If you get a bunch of...
and the tests run, then try again)The text was updated successfully, but these errors were encountered: