refactor: refactor package reading in test_requirements.py

Author: Molkree

test/test_requirements.py

@@ -29,38 +29,48 @@
 HTML_DEP_CSV = str(HTML_DEP_PATH_PATHLIB / "dependencies.csv")
 
 
-def get_out_of_sync_packages(csv_name: str, txt_name: str) -> tuple[set[str], set[str]]:
-    new_packages: set[str] = set()
-    removed_packages: set[str] = set()
+def get_packages_from_csv(csv_name: str) -> set[str]:
     csv_package_names: set[str] = set()
-    txt_package_names: set[str] = set()
-
-    with open(csv_name) as csv_file, open(txt_name) as txt_file:
+    with open(csv_name) as csv_file:
         csv_reader = csv.reader(csv_file)
         next(csv_reader)
         for _, product in csv_reader:
             csv_package_names.add(product)
+    return csv_package_names
+
+
+def get_packages_from_txt(txt_name: str) -> set[str]:
+    txt_package_names: set[str] = set()
+    with open(txt_name) as txt_file:
         lines = txt_file.readlines()
-        for line in lines:
-            txt_package_names.add(re.split(">|<|\\[|;|=|\n", line)[0])
-        new_packages = txt_package_names - csv_package_names
-        removed_packages = csv_package_names - txt_package_names
+    for line in lines:
+        txt_package_names.add(re.split(">|<|\\[|;|=|\n", line)[0])
+    return txt_package_names
+
 
+def get_out_of_sync_packages(
+    csv_packages: set[str], dependency_packages: set[str]
+) -> tuple[set[str], set[str]]:
+    new_packages = dependency_packages - csv_packages
+    removed_packages = csv_packages - dependency_packages
     return new_packages, removed_packages
 
 
 # Test to check if the requirements.csv files are in sync with requirements.txt files
 def test_txt_csv_sync() -> None:
     errors: set[str] = set()
 
-    (
-        req_new_packages,
-        req_removed_packages,
-    ) = get_out_of_sync_packages(REQ_CSV, REQ_TXT)
+    csv_packages = get_packages_from_csv(REQ_CSV)
+    dependency_packages = get_packages_from_txt(REQ_TXT)
+    req_new_packages, req_removed_packages = get_out_of_sync_packages(
+        csv_packages, dependency_packages
+    )
+    doc_csv_packages = get_packages_from_csv(DOC_CSV)
+    doc_dependency_packages = get_packages_from_txt(DOC_TXT)
     (
         doc_new_packages,
         doc_removed_packages,
-    ) = get_out_of_sync_packages(DOC_CSV, DOC_TXT)
+    ) = get_out_of_sync_packages(doc_csv_packages, doc_dependency_packages)
 
     if doc_removed_packages != set():
         errors.add(