Merge pull request #163 from elbeno/update-clang-tidy

🚨 Update clang-tidy for C++20 checks

Author: elbeno

.github/workflows/asciidoctor-ghpages.yml

@@ -35,7 +35,7 @@ jobs:
       - name: Checkout source
         uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
       - name: Setup Node.js
-        uses: actions/setup-node@0a44ba7841725637a19e28fa30b79a866c81b0a6 # v4.0.4
+        uses: actions/setup-node@39370e3970a6d050c480ffad4ff0ed4d3fdee5af # v4.1.0
         with:
           node-version: 20
       - name: Install Mermaid

.github/workflows/unit_tests.yml

@@ -268,7 +268,7 @@ jobs:
           CC: "/usr/lib/llvm-${{env.DEFAULT_LLVM_VERSION}}/bin/clang"
           CXX: "/usr/lib/llvm-${{env.DEFAULT_LLVM_VERSION}}/bin/clang++"
           PR_TARGET_BRANCH: ${{ steps.target_branch.outputs.branch }}
-        run: cmake -B ${{github.workspace}}/build -DCMAKE_CXX_STANDARD=17 -DCPM_SOURCE_CACHE=~/cpm-cache
+        run: cmake -B ${{github.workspace}}/build -DCMAKE_CXX_STANDARD=${{env.DEFAULT_CXX_STANDARD}} -DCPM_SOURCE_CACHE=~/cpm-cache
 
       - name: Save CPM cache
         env:

include/stdx/atomic.hpp

@@ -5,6 +5,7 @@
 #include <atomic>
 #include <type_traits>
 
+// NOLINTBEGIN(cppcoreguidelines-macro-usage)
 #if __cplusplus >= 202002L
 #define CPP20(...) __VA_ARGS__
 #else
@@ -123,3 +124,5 @@ template <typename T> class atomic {
 };
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(cppcoreguidelines-macro-usage)

include/stdx/atomic_bitset.hpp

@@ -50,6 +50,7 @@ class atomic_bitset {
         auto const len = std::min(n, str.size() - pos);
         auto const s = str.substr(pos, std::min(len, N));
         auto i = bit;
+        // NOLINTNEXTLINE(modernize-loop-convert)
         for (auto it = std::rbegin(s); it != std::rend(s); ++it) {
             if (*it == one) {
                 ret |= i;

include/stdx/bit.hpp

@@ -13,6 +13,8 @@
 #include <bit>
 #endif
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -357,3 +359,5 @@ template <std::size_t N> CONSTEVAL auto smallest_uint() {
 template <std::size_t N> using smallest_uint_t = decltype(smallest_uint<N>());
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)

include/stdx/bitset.hpp

@@ -153,6 +153,7 @@ class bitset {
         auto const len = std::min(n, str.size() - pos);
         auto i = std::size_t{};
         auto const s = str.substr(pos, std::min(len, N));
+        // NOLINTNEXTLINE(modernize-loop-convert)
         for (auto it = std::rbegin(s); it != std::rend(s); ++it) {
             set(i++, *it == one);
         }

include/stdx/byterator.hpp

@@ -10,6 +10,8 @@
 #include <iterator>
 #include <type_traits>
 
+// NOLINTBEGIN(modernize-use-constraints)
+
 namespace stdx {
 inline namespace v1 {
 
@@ -210,3 +212,5 @@ byterator(It) -> byterator<detail::iterator_value_t<It>>;
 
 } // namespace v1
 } // namespace stdx
+
+// NOLINTEND(modernize-use-constraints)

include/stdx/ct_string.hpp

@@ -14,7 +14,7 @@ inline namespace v1 {
 template <std::size_t N> struct ct_string {
     CONSTEVAL ct_string() = default;
 
-    // NOLINTNEXTLINE(*-avoid-c-arrays)
+    // NOLINTNEXTLINE(*-avoid-c-arrays, google-explicit-constructor)
     CONSTEVAL explicit(false) ct_string(char const (&str)[N]) {
         for (auto i = std::size_t{}; i < N; ++i) {
             // NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-*)

include/stdx/cx_map.hpp

@@ -37,6 +37,7 @@ template <typename Key, typename Value, std::size_t N> class cx_map {
 
   public:
     constexpr cx_map() = default;
+    // NOLINTNEXTLINE(modernize-use-constraints)
     template <typename... Vs, std::enable_if_t<((sizeof...(Vs) <= N) and ... and
                                                 stdx::same_as<value_type, Vs>),
                                                int> = 0>

include/stdx/cx_set.hpp

@@ -24,6 +24,7 @@ template <typename Key, std::size_t N> class cx_set {
 
     constexpr cx_set() = default;
     template <typename... Ts,
+              // NOLINTNEXTLINE(modernize-use-constraints)
               std::enable_if_t<((sizeof...(Ts) <= N) and ... and
                                 stdx::convertible_to<key_type, Ts>),
                                int> = 0>