Skip to content

fix scheduled jobs#652

Merged
m7pr merged 5 commits into
mainfrom
scheduled
Jun 24, 2025
Merged

fix scheduled jobs#652
m7pr merged 5 commits into
mainfrom
scheduled

Conversation

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr added the core label Jun 18, 2025
@github-actions

github-actions Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

Unit Tests Summary

  1 files   29 suites   33s ⏱️
369 tests 369 ✅ 0 💤 0 ❌
821 runs  821 ✅ 0 💤 0 ❌

Results for commit a7e2318.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jun 18, 2025

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                        Stmts    Miss  Cover    Missing
----------------------------  -------  ------  -------  -----------------------------------------------------------------------------------------------------------------------
R/calls_combine_by.R                7       0  100.00%
R/choices_labeled.R                49      14  71.43%   25, 36, 41, 51-56, 68, 72-76
R/count_labels.R                  102       0  100.00%
R/filter_panel_api.R               27       1  96.30%   132
R/FilteredData-utils.R             58      17  70.69%   38-43, 139, 161-170
R/FilteredData.R                  521     183  64.88%   109, 183, 322, 394, 481-490, 511, 529-587, 607-610, 654, 689, 709-725, 748-750, 753-767, 771-781, 784-826, 883, 895-915
R/FilteredDataset-utils.R          23       1  95.65%   125
R/FilteredDataset.R               268       6  97.76%   49, 150, 185, 210-211, 415
R/FilteredDatasetDataframe.R      123       3  97.56%   87, 148, 158
R/FilteredDatasetDefault.R         18       4  77.78%   104-117
R/FilteredDatasetMAE.R            133      15  88.72%   56, 118-123, 160-165, 169-170
R/FilterPanelAPI.R                 10       0  100.00%
R/FilterState-utils.R             101       2  98.02%   264, 294
R/FilterState.R                   366      62  83.06%   91, 152, 219, 237-241, 248-249, 263-264, 270-271, 325, 327, 329, 381, 424, 640, 683-706, 716-735, 770-776, 785-791
R/FilterStateChoices.R            352     109  69.03%   301, 368-375, 379-396, 423-426, 439-450, 462-470, 474-503, 523-526, 529-532, 542-567, 578, 583, 594
R/FilterStateDate.R               213     127  40.38%   230, 282-437
R/FilterStateDatettime.R          307     197  35.83%   266, 318-547
R/FilterStateEmpty.R               53      31  41.51%   89, 99-104, 117, 129-169
R/FilterStateExpr.R                81      66  18.52%   167-278
R/FilterStateLogical.R            194     142  26.80%   136, 158, 218, 222-404
R/FilterStateRange.R              410     107  73.90%   262, 384, 514-521, 524-534, 537, 548-554, 565-577, 581-591, 595-597, 610-636, 651, 654, 668-685, 720-725, 735-737
R/FilterStates-utils.R             70       7  90.00%   108, 127, 188-194
R/FilterStates.R                  373      20  94.64%   63, 89-93, 205, 424, 469, 503, 563-567, 612, 730-733
R/FilterStatesDF.R                  5       0  100.00%
R/FilterStatesMAE.R                10       1  90.00%   40
R/FilterStatesMatrix.R              7       0  100.00%
R/FilterStatesSE.R                188      34  81.91%   36, 73-75, 85-87, 125-132, 208, 229, 244-251, 259-266, 273
R/include_css_js.R                  5       0  100.00%
R/teal_slice.R                    108       4  96.30%   131, 195-196, 206
R/teal_slices.R                    85       5  94.12%   150-155
R/test_utils.R                     21       0  100.00%
R/utils.R                          26       0  100.00%
R/variable_types.R                 15       1  93.33%   48
R/zzz.R                            17      17  0.00%    3-47
TOTAL                            4346    1176  72.94%

Diff against main

Filename                Stmts    Miss  Cover
--------------------  -------  ------  -------
R/FilteredData.R            0      +1  -0.19%
R/FilteredDataset.R         0      +1  -0.37%
R/FilterStateRange.R        0      +3  -0.73%
R/FilterStates.R            0      +1  -0.27%
TOTAL                       0      +6  -0.14%

Results for commit: a7e2318

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

m7pr added 3 commits June 18, 2025 11:32
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Comment thread DESCRIPTION Outdated
@m7pr
m7pr requested a review from averissimo June 19, 2025 11:44
@m7pr m7pr changed the title WIP - fix scheduled jobs fix scheduled jobs Jun 23, 2025
@m7pr
m7pr requested a review from llrs-roche June 23, 2025 12:40

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and all the strategies pass. Please add the minimal version for two packages without minimal version (MAE and SummarizedExperiment).

@llrs-roche llrs-roche self-assigned this Jun 24, 2025
@m7pr

m7pr commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

Hey @llrs-roche let's skip setting versions for Bioconductor packages.
This build will use the specific Bioconductor snapshot so will pull always the same version. We have no way testing smaller/older versions. This pipeline uses the newest version of Bioconductor and the newest Bioconductor packages were pulled.

We had this conversation with the team in the past before, about those 2 bioc packages in teal.slice. It should be ok as it is.

@llrs-roche llrs-roche left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Yes, Bioconductor is tied to an R release but I thought that setting the minimal version of the first time they were supported wouldn't hurt. Basically it would prevent to install the package on a mix of versions between CRAN and Bioconductor (but this will be a super rare case). But if this has been the team decision let's move forward without it

@m7pr

m7pr commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

There isn't a way to test old versions (automatically with this pipeline), but we don't want to specify a limit, in case some older version works

@m7pr
m7pr merged commit c667080 into main Jun 24, 2025
37 checks passed
@m7pr
m7pr deleted the scheduled branch June 24, 2025 10:48
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants