Conversation
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Unit Tests Summary 1 files 29 suites 33s ⏱️ Results for commit a7e2318. ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: a7e2318 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
llrs-roche
left a comment
There was a problem hiding this comment.
Looks good, and all the strategies pass. Please add the minimal version for two packages without minimal version (MAE and SummarizedExperiment).
|
Hey @llrs-roche let's skip setting versions for Bioconductor packages. We had this conversation with the team in the past before, about those 2 bioc packages in teal.slice. It should be ok as it is. |
llrs-roche
left a comment
There was a problem hiding this comment.
Approved.
Yes, Bioconductor is tied to an R release but I thought that setting the minimal version of the first time they were supported wouldn't hurt. Basically it would prevent to install the package on a mix of versions between CRAN and Bioconductor (but this will be a super rare case). But if this has been the team decision let's move forward without it
|
There isn't a way to test old versions (automatically with this pipeline), but we don't want to specify a limit, in case some older version works |
Running dependency tests: