refactor: improve message and test if specific message is triggered when warning

Author: osenan

R/qenv-within.R

@@ -56,7 +56,7 @@ side_effect_functions <- c("set.seed", "options", "Sys.setenv")
 within.qenv <- function(data, expr, ...) {
   expr <- as.expression(substitute(expr))
   if (grepl(paste(side_effect_functions, collapse = "|"), as.character(expr))) {
-    warning("Calls to options and set.seed might not be reproducible with `get_code`, use `eval_code` instead")
+    warning("Calls to side effect functions might not be reproducible with `get_code`, use `eval_code` instead")
   }
   extras <- list(...)
   # Inject extra values into expressions.

tests/testthat/test-qenv_within.R

@@ -126,7 +126,8 @@ testthat::test_that("within triggers warning if side_effect_functions used", {
       set.seed(2)
       a <- runif(1)
     })
-  })
+  },
+  "Calls to side effect functions might not be reproducible with `get_code`, use `eval_code` instead")
 
   testthat::expect_warning({
     within(qenv(), {