Cleanup remaining todos and unused code

Author: ch1bo

ui/src/components/Sim/types.ts

@@ -84,7 +84,6 @@ export interface ITransactionSent {
   recipient: string;
 }
 
-
 export interface IRankingBlockGenerated {
   type: EServerMessageType.RBGenerated;
   id: string;
@@ -133,7 +132,6 @@ export interface ITransaction {
   id: string;
 }
 
-
 export interface IEndorserBlock {
   id: string;
 }
@@ -198,7 +196,6 @@ export type TServerMessageType =
   | ITransactionSent
   | IUnknown;
 
-// TODO: should rename ServerMessage -> ServerMessage
 export interface IServerMessage<T = TServerMessageType> {
   time_s: number;
   message: T;

ui/src/contexts/SimContext/context.ts

@@ -7,7 +7,6 @@ import {
 } from "./types";
 
 export const defaultAggregatedData: ISimulationAggregatedDataState = {
-  progress: 0,
   nodes: new Map(),
   global: {
     praosTxOnChain: 0,

ui/src/contexts/SimContext/reducer.ts

@@ -1,6 +1,9 @@
 import { defaultAggregatedData } from "./context";
 import { ISimContextState, TSimContextActions } from "./types";
-import { computeAggregatedDataAtTime, clearLatencyCache } from "@/utils/timelineAggregation";
+import {
+  computeAggregatedDataAtTime,
+  clearLatencyCache,
+} from "@/utils/timelineAggregation";
 
 export const reducer = (
   state: ISimContextState,
@@ -46,7 +49,6 @@ export const reducer = (
       };
     }
 
-
     case "SET_CURRENT_NODE": {
       return {
         ...state,
@@ -57,8 +59,6 @@ export const reducer = (
       };
     }
 
-
-
     case "SET_CANVAS_PROPS": {
       return {
         ...state,
@@ -80,13 +80,6 @@ export const reducer = (
       };
     }
 
-    case "SET_SPEED": {
-      return {
-        ...state,
-        speedMultiplier: action.payload.speedMultiplier,
-      };
-    }
-
     case "BATCH_UPDATE": {
       return {
         ...state,
@@ -114,12 +107,6 @@ export const reducer = (
         topologyLoaded: true,
       };
 
-    case "ADD_TIMELINE_EVENT":
-      return {
-        ...state,
-        events: [...state.events, action.payload],
-      };
-
     case "ADD_TIMELINE_EVENT_BATCH":
       return {
         ...state,
@@ -164,7 +151,6 @@ export const reducer = (
         speedMultiplier: action.payload,
       };
 
-
     case "RESET_TIMELINE":
       return {
         ...state,

ui/src/contexts/SimContext/types.ts

@@ -1,13 +1,6 @@
 import { IServerMessage, ITransformedNodeMap } from "@/components/Sim/types";
 import { Dispatch, RefObject } from "react";
 
-// TODO: unused
-export enum ESpeedOptions {
-  "1% Speed" = 0.01,
-  "3% Speed" = 0.03,
-  "10% Speed" = 0.1,
-}
-
 // Types of messages submitted between nodes
 export enum EMessageType {
   EB = "eb",
@@ -51,7 +44,6 @@ export interface IMessageAnimation {
 }
 
 export interface ISimulationAggregatedDataState {
-  progress: number; // TODO: unused
   nodes: Map<string, ISimulationAggregatedData>;
   global: ISimulationGlobalData;
   lastNodesUpdated: string[];
@@ -98,12 +90,6 @@ export type TSimContextActions =
   | { type: "SET_SCENARIOS"; payload: IScenario[] }
   | { type: "SET_SCENARIO"; payload: string }
   | { type: "SET_CURRENT_NODE"; payload: string | undefined }
-  | {
-      type: "SET_SPEED";
-      payload: {
-        speedMultiplier: number;
-      };
-    }
   | {
       type: "SET_CANVAS_PROPS";
       payload: Partial<{
@@ -112,26 +98,13 @@ export type TSimContextActions =
         canvasOffsetY: ((prev: number) => number) | number;
       }>;
     }
-  | {
-      type: "BATCH_UPDATE";
-      payload: Partial<ISimContextState>;
-    }
+  | { type: "BATCH_UPDATE"; payload: Partial<ISimContextState> }
   | { type: "RESET_TOPOLOGY"; payload: string }
   | {
       type: "SET_TOPOLOGY";
-      payload: {
-        topologyPath: string;
-        topology: ITransformedNodeMap;
-      };
-    }
-  | {
-      type: "ADD_TIMELINE_EVENT";
-      payload: IServerMessage;
-    }
-  | {
-      type: "ADD_TIMELINE_EVENT_BATCH";
-      payload: IServerMessage[];
+      payload: { topologyPath: string; topology: ITransformedNodeMap };
     }
+  | { type: "ADD_TIMELINE_EVENT_BATCH"; payload: IServerMessage[] }
   | { type: "SET_TIMELINE_TIME"; payload: number }
   | { type: "SET_TIMELINE_PLAYING"; payload: boolean }
   | { type: "SET_TIMELINE_SPEED"; payload: number }

ui/src/utils/timelineAggregation.ts

@@ -132,20 +132,26 @@ export const computeAggregatedDataAtTime = (
   const messageBytes = new Map<EMessageType, Map<string, number>>();
 
   // Helper functions for efficient byte storage/retrieval
-  const setMessageBytes = (messageType: EMessageType, messageId: string, size: number) => {
+  const setMessageBytes = (
+    messageType: EMessageType,
+    messageId: string,
+    size: number,
+  ) => {
     if (!messageBytes.has(messageType)) {
       messageBytes.set(messageType, new Map());
     }
     messageBytes.get(messageType)!.set(messageId, size);
   };
 
-  const getMessageBytes = (messageType: EMessageType, messageId: string): number => {
+  const getMessageBytes = (
+    messageType: EMessageType,
+    messageId: string,
+  ): number => {
     return messageBytes.get(messageType)?.get(messageId) || 0;
   };
 
   // Initialize result structure
   const result: ISimulationAggregatedDataState = {
-    progress: targetTime,
     nodes: nodeStats,
     global: {
       praosTxOnChain: 0,
@@ -182,7 +188,10 @@ export const computeAggregatedDataAtTime = (
       case EServerMessageType.TransactionGenerated: {
         const stats = nodeStats.get(message.publisher);
         if (stats) {
-          stats.generated.set(EMessageType.TX, (stats.generated.get(EMessageType.TX) || 0) + 1);
+          stats.generated.set(
+            EMessageType.TX,
+            (stats.generated.get(EMessageType.TX) || 0) + 1,
+          );
           setMessageBytes(EMessageType.TX, message.id, message.size_bytes);
         }
         break;
@@ -231,13 +240,13 @@ export const computeAggregatedDataAtTime = (
         break;
       }
 
-
-
-
       case EServerMessageType.EBGenerated: {
         const stats = nodeStats.get(message.producer);
         if (stats) {
-          stats.generated.set(EMessageType.EB, (stats.generated.get(EMessageType.EB) || 0) + 1);
+          stats.generated.set(
+            EMessageType.EB,
+            (stats.generated.get(EMessageType.EB) || 0) + 1,
+          );
           setMessageBytes(EMessageType.EB, message.id, message.size_bytes);
         }
 
@@ -316,7 +325,10 @@ export const computeAggregatedDataAtTime = (
       case EServerMessageType.RBGenerated: {
         const stats = nodeStats.get(message.producer);
         if (stats) {
-          stats.generated.set(EMessageType.RB, (stats.generated.get(EMessageType.RB) || 0) + 1);
+          stats.generated.set(
+            EMessageType.RB,
+            (stats.generated.get(EMessageType.RB) || 0) + 1,
+          );
           setMessageBytes(EMessageType.RB, message.id, message.size_bytes);
         }
 
@@ -396,7 +408,10 @@ export const computeAggregatedDataAtTime = (
       case EServerMessageType.VTBundleGenerated: {
         const stats = nodeStats.get(message.producer);
         if (stats) {
-          stats.generated.set(EMessageType.Votes, (stats.generated.get(EMessageType.Votes) || 0) + 1);
+          stats.generated.set(
+            EMessageType.Votes,
+            (stats.generated.get(EMessageType.Votes) || 0) + 1,
+          );
           setMessageBytes(EMessageType.Votes, message.id, message.size_bytes);
         }
         break;