[ETCM-1152] Remove double call to appStateStorage.getBestBlockNumber() in getBestBranch() (#1115)

Leonor Boga · web-flow · commit 40c82e8257bc · 2021-09-20T12:44:06.000+02:00
diff --git a/src/main/scala/io/iohk/ethereum/domain/BlockchainReader.scala b/src/main/scala/io/iohk/ethereum/domain/BlockchainReader.scala
@@ -78,7 +78,6 @@ class BlockchainReader(
     val number = getBestBlockNumber()
     blockNumberMappingStorage
       .get(number)
-      .orElse(blockNumberMappingStorage.get(appStateStorage.getBestBlockNumber()))
       .map(hash => BestBranch(hash, number))
       .getOrElse(EmptyBranch)
   }

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,6 @@ class BlockchainReader(`
`78`	`78`	`val number = getBestBlockNumber()`
`79`	`79`	`blockNumberMappingStorage`
`80`	`80`	`.get(number)`
`81`		`- .orElse(blockNumberMappingStorage.get(appStateStorage.getBestBlockNumber()))`
`82`	`81`	`.map(hash => BestBranch(hash, number))`
`83`	`82`	`.getOrElse(EmptyBranch)`
`84`	`83`	`}`