fix(cardano-services): do not return datum hash for TxOut with inline datum

Author: mkazlauskas

packages/cardano-services/src/Utxo/DbSyncUtxoProvider/mappers.ts

@@ -90,8 +90,11 @@ export const utxosToCore = (utxosModels: UtxoModel[]): Cardano.Utxo[] => {
           coins: BigInt(current.coins)
         }
       };
-      if (isNotNil(current.data_hash)) txOut.datumHash = current.data_hash as unknown as Hash32ByteBase16;
-      if (isNotNil(current.inline_datum)) txOut.datum = PlutusData.fromCbor(HexBlob(current.inline_datum)).toCore();
+      if (isNotNil(current.inline_datum)) {
+        txOut.datum = PlutusData.fromCbor(HexBlob(current.inline_datum)).toCore();
+      } else if (isNotNil(current.data_hash)) {
+        txOut.datumHash = current.data_hash as unknown as Hash32ByteBase16;
+      }
       if (isNotNil(current.reference_script_type)) txOut.scriptReference = parseReferenceScript(current);
 
       if (isNotNil(current.asset_name) && current.asset_policy && current.asset_quantity) {

packages/cardano-services/test/Utxo/UtxoHttpService.test.ts

@@ -11,8 +11,6 @@ import {
   UNLIMITED_CACHE_TTL,
   UtxoHttpService
 } from '../../src';
-import { Hash32ByteBase16 } from '@cardano-sdk/crypto';
-import { HexBlob } from '@cardano-sdk/util';
 import { INFO, createLogger } from 'bunyan';
 import { OgmiosCardanoNode } from '@cardano-sdk/ogmios';
 import { Pool } from 'pg';
@@ -169,12 +167,10 @@ describe('UtxoHttpService', () => {
       it('return UTxO with inline datum', async () => {
         const addresses = await fixtureBuilder.getAddresses(1, { with: [AddressWith.InlineDatum] });
         const res: Cardano.Utxo[] = await provider.utxoByAddresses({ addresses });
-        const firstTxOut = res[0][1];
 
         expect(res.length).toBeGreaterThan(0);
         expect(res[0]).toMatchShapeOf([DataMocks.Tx.input, DataMocks.Tx.outputWithInlineDatum]);
-        expect(() => HexBlob(firstTxOut.datum! as unknown as string)).not.toThrow();
-        expect(() => Hash32ByteBase16(firstTxOut.datumHash! as unknown as string)).not.toThrow();
+        expect(res[0][1].datumHash).toBeUndefined();
       });
 
       it('return UTxO with time lock reference script', async () => {