From f892f1a618ca16dbd5abd3dd2a35dbde1a32899e Mon Sep 17 00:00:00 2001 From: Matt Lavin Date: Tue, 10 Dec 2024 10:14:18 -0500 Subject: [PATCH 1/2] Small conditional support fixes --- packages/workflow/src/builtin.ts | 4 ++-- packages/workflow/src/interpolation.ts | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/workflow/src/builtin.ts b/packages/workflow/src/builtin.ts index a6a1d86..5a2bfeb 100644 --- a/packages/workflow/src/builtin.ts +++ b/packages/workflow/src/builtin.ts @@ -47,8 +47,8 @@ export const builtinActions: Record = { edges: { allowAdd: false, edges: [ - { name: "True", conditional: { type: "if", ref: "!ref($.result)" } }, - { name: "False", conditional: { type: "else", ref: "!ref($.result)" } }, + { name: "True", conditional: { type: "if", ref: "!ref($.output.result)" } }, + { name: "False", conditional: { type: "else", ref: "!ref($.output.result)" } }, ] }, } diff --git a/packages/workflow/src/interpolation.ts b/packages/workflow/src/interpolation.ts index 9af41a4..cb468ba 100644 --- a/packages/workflow/src/interpolation.ts +++ b/packages/workflow/src/interpolation.ts @@ -59,8 +59,6 @@ export function refs(input: any): Array<{ path: string, ref: string }> { export function interpolate(value: any, vars: Record) { let result = value; - // TODO: Handle $.result - if (isRef(result)) { // Handle pure references immediately. Remove "!ref(" and ")" result = result.replace("!ref(", "") From 706ac5396a95f3ef8d18547e257d1728b6bb3cbb Mon Sep 17 00:00:00 2001 From: Matt Lavin Date: Tue, 10 Dec 2024 10:17:38 -0500 Subject: [PATCH 2/2] Add changeset --- .changeset/healthy-shoes-hear.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/healthy-shoes-hear.md diff --git a/.changeset/healthy-shoes-hear.md b/.changeset/healthy-shoes-hear.md new file mode 100644 index 0000000..2fc4149 --- /dev/null +++ b/.changeset/healthy-shoes-hear.md @@ -0,0 +1,5 @@ +--- +"@inngest/workflow-kit": patch +--- + +Minor improvements to conditional support