Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The issue of Korean character fragmentation in Inky #933

Open
cheng80 opened this issue Jan 23, 2025 · 6 comments
Open

The issue of Korean character fragmentation in Inky #933

cheng80 opened this issue Jan 23, 2025 · 6 comments

Comments

@cheng80
Copy link

cheng80 commented Jan 23, 2025

When using Inkle Studio’s narrative scripting language editor, Inky, on a Mac, Korean characters written in Unicode often appear fragmented, making it impossible to display them correctly.

This issue seems to stem from Ink utilizing the NFD (Normalization Form Canonical Decomposition) method for Unicode normalization, rather than NFC (Normalization Form Canonical Composition). To display Korean characters correctly, the NFC normalization form must be used.

@cheng80 cheng80 changed the title The issue of Korean character fragmentation in Ink The issue of Korean character fragmentation in Inky Jan 23, 2025
@rhizoome
Copy link

rhizoome commented Jan 28, 2025

I tried to reproduce this with

->hangul겺겻겼test->

=== hangul겺겻겼test ===
hangul겺겻겼test
->->

but the above works. Can you send a file that fails?

Also

  1. You should probably submit the issue to: https://github.com/inkle/inky
  2. Autocompletion for unicode is actually not supported since the version of ace editor used in inky does not yet support unicode regex. Because of that I'd recommend using ascii only for symbols like knots and variables.

@rhizoome
Copy link

rhizoome commented Feb 4, 2025

The tree-siitter-ink project should support unicode fully #934, but I need to implement a language-server based on tree-sitter-ink before it is a full IDE:

@ffdd270
Copy link

ffdd270 commented Feb 14, 2025

This is input issue : Check this video.

2025-02-14.2.31.57.mov

@ffdd270
Copy link

ffdd270 commented Feb 14, 2025

This is the Korean input result I expected.

2025-02-14.2.34.36.mov

@cheng80
Copy link
Author

cheng80 commented Feb 14, 2025

That's right. That's the problem. So currently, I work in VS code and only check the results and errors in the Inky editor.

@rhizoome
Copy link

Ok. I tested with the virtual unicode entry system in MacOS. It seems to be very different to you using a real korean keyboard. Something like that might be fixable by updating Electron and AceJS. If you want try yourself it isn‘t too difficult.

https://github.com/inkle/inky?tab=readme-ov-file#help-develop-inky

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants