Acknowledge external events after handoff

Author: dimavrem22

src/gateway/dispatch.ts

@@ -50,7 +50,11 @@ export interface DispatchDeps {
 // may retry); filtered/ignored events return true (ack, no retry).
 export async function dispatchEvent(deps: DispatchDeps, event: VerifiedEvent): Promise<boolean> {
   if (event.provider !== "inkbox") {
-    if (deps.onExternal) await deps.onExternal(event);
+    if (deps.onExternal) {
+      void deps
+        .onExternal(event)
+        .catch((error) => deps.logger.error("external.dispatch_failed", { error: String(error) }));
+    }
     return true;
   }
   const type = event.eventType ?? inferType(event.body);

tests/gateway/dispatch.test.ts

@@ -435,8 +435,14 @@ describe("dispatchEvent sender agent identity", () => {
 });
 
 describe("dispatchEvent external providers", () => {
-  it("hands a non-inkbox event to onExternal and acks", async () => {
-    const onExternal = vi.fn(async () => {});
+  it("hands a non-inkbox event to onExternal and acks without waiting for the turn", async () => {
+    let finish: () => void = () => {};
+    const onExternal = vi.fn(
+      () =>
+        new Promise<void>((resolve) => {
+          finish = resolve;
+        }),
+    );
     const deps = makeDeps({ onExternal });
     const external: VerifiedEvent = {
       provider: "github",
@@ -451,6 +457,28 @@ describe("dispatchEvent external providers", () => {
     expect(ok).toBe(true);
     expect(onExternal).toHaveBeenCalledWith(external);
     expect(deps.sessions.handleInbound).not.toHaveBeenCalled();
+    finish();
+  });
+
+  it("logs an external turn rejected after acknowledgement", async () => {
+    const onExternal = vi.fn(async () => {
+      throw new Error("capture failed");
+    });
+    const deps = makeDeps({ onExternal });
+    const external: VerifiedEvent = {
+      provider: "github",
+      verified: true,
+      eventType: "push",
+      body: { ref: "refs/heads/main" },
+      headers: {},
+    };
+
+    await expect(dispatchEvent(deps, external)).resolves.toBe(true);
+    await vi.waitFor(() =>
+      expect(deps.logger.error).toHaveBeenCalledWith("external.dispatch_failed", {
+        error: "Error: capture failed",
+      }),
+    );
   });
 });
 

tests/live/external-event.test.ts

@@ -25,7 +25,7 @@ function workflowRunBody(runId: string): string {
       name: "CI",
       event: "pull_request",
       status: "completed",
-      conclusion: "failure",
+      conclusion: "success",
       head_branch: "main",
       html_url: `https://github.com/${repository}/actions/runs/${runId}`,
     },