impv(db): update valid tables methods

Author: traviolus

informative-indexer/db/db.go

@@ -135,16 +135,14 @@ func GetRowCount(ctx context.Context, dbClient Queryable, table string) (int64,
 }
 
 func GetRowsToPruneByBlockHeight(ctx context.Context, dbClient Queryable, table string, threshold int64) (pgx.Rows, error) {
-	if !isValidTableName(table) {
+	t, ok := ValidTablesMap[table]
+	if !ok {
 		return nil, fmt.Errorf("invalid table name: %s", table)
+
 	}
 
-	var query string
-	t := ValidTablesMap[table]
 	columns := getColumns(t)
-
-	query = fmt.Sprintf("SELECT %s FROM %s WHERE block_height <= $1", strings.Join(columns, ", "), table)
-
+	query := fmt.Sprintf("SELECT %s FROM %s WHERE block_height <= $1", strings.Join(columns, ", "), table)
 	rows, err := QueryRowsWithTimeout(ctx, dbClient, query, threshold)
 	if err != nil {
 		return nil, fmt.Errorf("failed to get rows to prune from table %s: %w", table, err)

informative-indexer/db/valid_tables.go

@@ -13,12 +13,8 @@ var ValidTablesMap = map[string]ValidTable{
 }
 
 func isValidTableName(tableName string) bool {
-	for validTable, _ := range ValidTablesMap {
-		if tableName == validTable {
-			return true
-		}
-	}
-	return false
+	_, ok := ValidTablesMap[tableName]
+	return ok
 }
 
 func GetValidTableNames() []string {