Skip to content

Commit 7f1d6f9

Browse files
committed
Remove tests for Rails versions less or equal to 5.1
1 parent cc20e7c commit 7f1d6f9

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

spec/requests/active_record_sql_metrics_spec.rb

-33
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
end
1515

1616
it "writes metric" do
17-
skip("https://github.com/rails/rails/issues/30586") unless payload_names_fixed_in_rails?
18-
1917
get "/metrics"
2018

2119
expect_metric(
@@ -34,27 +32,6 @@
3432
)
3533
end
3634

37-
it "writes metric" do
38-
skip("https://github.com/rails/rails/issues/30586") if payload_names_fixed_in_rails?
39-
40-
get "/metrics"
41-
42-
expect_metric(
43-
tags: a_hash_including(
44-
hook: "sql",
45-
name: "SQL",
46-
class_name: "SQL",
47-
operation: "INSERT"
48-
),
49-
fields: a_hash_including(
50-
additional_field: :value,
51-
request_id: :request_id,
52-
value: be_between(1, 500),
53-
sql: "INSERT INTO \"metrics\" (\"name\", \"created_at\", \"updated_at\") VALUES (xxx)"
54-
)
55-
)
56-
end
57-
5835
it "includes correct timestamps" do
5936
travel_to Time.zone.local(2018, 1, 1, 9, 0, 0)
6037

@@ -80,14 +57,4 @@
8057
)
8158
)
8259
end
83-
84-
def payload_names_fixed_in_rails?
85-
Rails::VERSION::MAJOR > 5 ||
86-
rails_after_5_1?
87-
end
88-
89-
def rails_after_5_1?
90-
Rails::VERSION::MAJOR == 5 &&
91-
Rails::VERSION::MINOR > 1
92-
end
9360
end

0 commit comments

Comments
 (0)