Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

Commit 2e9c63e

Browse files
committed
Move ignored_environments stubbing to spec helper
as it is needed in all specs anyway.
1 parent 3e06d54 commit 2e9c63e

8 files changed

+3
-14
lines changed

spec/requests/action_controller_metrics_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
end
88
end
99
before do
10-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
1110
allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
1211
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:application_name).and_return(:app_name)
1312
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:tags_middleware).and_return(tags_middleware)

spec/requests/action_view_collection_metrics_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
end
88
end
99
before do
10-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
1110
allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
1211
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:application_name).and_return(:app_name)
1312
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:tags_middleware).and_return(tags_middleware)

spec/requests/action_view_partial_metrics_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
end
88
end
99
before do
10-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
1110
allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
1211
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:application_name).and_return(:app_name)
1312
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:tags_middleware).and_return(tags_middleware)

spec/requests/action_view_template_metrics_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
end
88
end
99
before do
10-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
1110
allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
1211
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:application_name).and_return(:app_name)
1312
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:tags_middleware).and_return(tags_middleware)

spec/requests/active_record_metrics_spec.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
end
88
end
99
before do
10-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
1110
allow_any_instance_of(ActionDispatch::Request).to receive(:request_id).and_return(:request_id)
1211
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:application_name).and_return(:app_name)
1312
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:tags_middleware).and_return(tags_middleware)

spec/requests/context_spec.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
require File.dirname(__FILE__) + "/../spec_helper"
22

33
RSpec.describe "Context", type: :request do
4-
before do
5-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
6-
end
7-
84
it "resets the context after a request" do
95
get "/metrics"
106

spec/requests/logger_spec.rb

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
11
require File.dirname(__FILE__) + "/../spec_helper"
22

3-
RSpec.describe "Context", type: :request do
4-
before do
5-
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
6-
end
7-
3+
RSpec.describe "Logger", type: :request do
84
it "logs exception" do
95
setup_broken_client
106
expect(Rails.logger).to receive(:error).with(/message/).at_least(:once)

spec/spec_helper.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@
3535
InfluxDB::Rails.configure
3636

3737
allow(InfluxDB::Rails).to receive(:client).and_return(InfluxDB::Rails::TestClient.new)
38+
allow_any_instance_of(InfluxDB::Rails::Configuration).to receive(:ignored_environments).and_return(%w[development])
39+
3840
InfluxDB::Rails::TestClient.metrics.clear
3941
end
4042

0 commit comments

Comments
 (0)