Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Use lefthook to run link checking on pre-commit #5887

Open
jstirnaman opened this issue Mar 12, 2025 · 0 comments · May be fixed by #5889
Open

CI: Use lefthook to run link checking on pre-commit #5887

jstirnaman opened this issue Mar 12, 2025 · 0 comments · May be fixed by #5889
Assignees
@jstirnaman

Comments

@jstirnaman
Copy link
Contributor

jstirnaman commented Mar 12, 2025 •
edited
Loading

  1. Improve the Cypress test for checking article links
  • Handle anchor links, warn about missing anchors
  • Handle download links--only check for a success header without downloading the file

  1. Add lefthook.yml pre-commit commands to run the test for staged files for each product/version.

  2. Map staged file paths to their URLs and pass them to the link checking test. It needs to work for both cypress open --e2e (for debugging in the UI) and cypress run (in the terminal).

  3. Update package.json scripts
@jstirnaman jstirnaman self-assigned this Mar 12, 2025
jstirnaman added a commit that referenced this issue Mar 12, 2025
@jstirnaman
fix(v3-enterprise): Closes #5887: Enterprise get-started is missing w…
b5a7f27 
…rite path steps and recent fixes
@jstirnaman jstirnaman closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2025
@jstirnaman jstirnaman changed the title Enterprise get-started is missing write path steps and recent fixes CI: Use lefthook to run link checking on pre-commit Mar 12, 2025
@jstirnaman jstirnaman reopened this Mar 12, 2025
jstirnaman added a commit that referenced this issue Mar 12, 2025
@jstirnaman
chore(ci): closes #5887 Improve and automate pre-commit link-checking
cfe3c40
jstirnaman added a commit that referenced this issue Mar 12, 2025
@jstirnaman
chore(ci): closes #5887 Improve and automate pre-commit link-checking
ff72acf
jstirnaman added a commit that referenced this issue Mar 12, 2025
@jstirnaman
chore(ci): closes #5887 Improve and automate pre-commit link-checking
bfb9185
@jstirnaman jstirnaman linked a pull request Mar 12, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jstirnaman jstirnaman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Automate link-checking influxdata/docs-v2
1 participant
@jstirnaman