Run rubocop -A for all touched files

Author: skryukov

Diff for: .rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config --exclude-limit 10000`
-# on 2025-03-04 09:53:10 UTC using RuboCop version 1.73.2.
+# on 2025-04-10 07:53:12 UTC using RuboCop version 1.75.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -54,11 +54,10 @@ Layout/FirstArgumentIndentation:
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
+# Configuration parameters: IndentationWidth.
 # SupportedStyles: special_inside_parentheses, consistent, align_braces
 Layout/FirstHashElementIndentation:
-  Exclude:
-    - 'spec/inertia/rspec_helper_spec.rb'
+  EnforcedStyle: consistent
 
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
@@ -68,14 +67,13 @@ Layout/MultilineMethodCallIndentation:
   Exclude:
     - 'spec/inertia/ssr_spec.rb'
 
-# Offense count: 6
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces.
 # SupportedStyles: space, no_space
 # SupportedStylesForEmptyBraces: space, no_space
 Layout/SpaceBeforeBlockBraces:
   Exclude:
-    - 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
     - 'spec/inertia/error_sharing_spec.rb'
     - 'spec/inertia/request_spec.rb'
 
@@ -127,13 +125,12 @@ Layout/TrailingEmptyLines:
     - 'lib/tasks/inertia_rails.rake'
     - 'spec/inertia/rails_mimic_spec.rb'
 
-# Offense count: 10
+# Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
     - 'lib/inertia_rails/rspec.rb'
-    - 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
     - 'spec/dummy/config/environments/test.rb'
 
 # Offense count: 1
@@ -164,14 +161,6 @@ Lint/SymbolConversion:
   Exclude:
     - 'spec/inertia/rails_mimic_spec.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods, NotImplementedExceptions.
-# NotImplementedExceptions: NotImplementedError
-Lint/UnusedMethodArgument:
-  Exclude:
-    - 'lib/patches/mapper.rb'
-
 # Offense count: 1
 Naming/AccessorMethodName:
   Exclude:
@@ -190,7 +179,7 @@ Naming/FileName:
 # Offense count: 2
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
 Naming/VariableNumber:
   Exclude:
     - 'spec/dummy/app/controllers/inertia_test_controller.rb'
@@ -214,8 +203,10 @@ Style/BlockDelimiters:
 
 # Offense count: 1
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
 # SupportedStyles: nested, compact
+# SupportedStylesForClasses: , nested, compact
+# SupportedStylesForModules: , nested, compact
 Style/ClassAndModuleChildren:
   Exclude:
     - 'lib/inertia_rails/helper.rb'
@@ -255,7 +246,7 @@ Style/ExpandPathArguments:
   Exclude:
     - 'spec/rails_helper.rb'
 
-# Offense count: 69
+# Offense count: 67
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, always_true, never
@@ -267,7 +258,6 @@ Style/FrozenStringLiteralComment:
     - 'lib/inertia_rails/controller.rb'
     - 'lib/inertia_rails/engine.rb'
     - 'lib/inertia_rails/helper.rb'
-    - 'lib/inertia_rails/inertia_rails.rb'
     - 'lib/inertia_rails/rspec.rb'
     - 'lib/inertia_rails/version.rb'
     - 'lib/patches/better_errors.rb'
@@ -287,7 +277,6 @@ Style/FrozenStringLiteralComment:
     - 'spec/dummy/app/controllers/inertia_merge_shared_controller.rb'
     - 'spec/dummy/app/controllers/inertia_multithreaded_share_controller.rb'
     - 'spec/dummy/app/controllers/inertia_rails_mimic_controller.rb'
-    - 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
     - 'spec/dummy/app/controllers/inertia_responders_test_controller.rb'
     - 'spec/dummy/app/controllers/inertia_session_continuity_test_controller.rb'
     - 'spec/dummy/app/controllers/inertia_share_test_controller.rb'
@@ -369,14 +358,13 @@ Style/IfUnlessModifierOfIfUnless:
   Exclude:
     - 'lib/inertia_rails/controller.rb'
 
-# Offense count: 3
+# Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: line_count_dependent, lambda, literal
 Style/Lambda:
   Exclude:
     - 'spec/dummy/app/controllers/inertia_lambda_shared_props_controller.rb'
-    - 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
     - 'spec/dummy/app/controllers/transformed_inertia_rails_mimic_controller.rb'
 
 # Offense count: 1
@@ -446,7 +434,7 @@ Style/SoleNestedConditional:
   Exclude:
     - 'lib/inertia_rails/controller.rb'
 
-# Offense count: 78
+# Offense count: 80
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
@@ -495,7 +483,7 @@ Style/TrailingCommaInArguments:
     - 'spec/dummy/app/controllers/inertia_config_test_controller.rb'
     - 'spec/dummy/app/controllers/inertia_rails_mimic_controller.rb'
 
-# Offense count: 22
+# Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, diff_comma, no_comma
@@ -505,21 +493,20 @@ Style/TrailingCommaInHashLiteral:
     - 'spec/dummy/app/controllers/inertia_lambda_shared_props_controller.rb'
     - 'spec/dummy/app/controllers/inertia_merge_instance_props_controller.rb'
     - 'spec/dummy/app/controllers/inertia_merge_shared_controller.rb'
-    - 'spec/dummy/app/controllers/inertia_render_test_controller.rb'
     - 'spec/dummy/config/environments/development.rb'
     - 'spec/dummy/config/environments/test.rb'
     - 'spec/inertia/response_spec.rb'
     - 'spec/inertia/rspec_helper_spec.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, MinSize, WordRegex.
+# Configuration parameters: WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
-  Exclude:
-    - 'lib/inertia_rails/middleware.rb'
+  EnforcedStyle: percent
+  MinSize: 4
 
-# Offense count: 17
+# Offense count: 19
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https

Diff for: lib/inertia_rails/inertia_rails.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'inertia_rails/base_prop'
 require 'inertia_rails/ignore_on_first_load_prop'
 require 'inertia_rails/always_prop'

Diff for: spec/dummy/app/controllers/inertia_render_test_controller.rb

@@ -1,9 +1,10 @@
+# frozen_string_literal: true
+
 class InertiaRenderTestController < ApplicationController
-  
   def props
     render inertia: 'TestComponent', props: {
       name: 'Brandon',
-      sport: -> { 'hockey' }
+      sport: -> { 'hockey' },
     }
   end
 
@@ -18,9 +19,9 @@ def except_props
       end,
       nested: {
         first: 'first nested param',
-        second: 'second nested param'
+        second: 'second nested param',
       },
-      always: InertiaRails.always { 'always prop' }
+      always: InertiaRails.always { 'always prop' },
     }
   end
 
@@ -36,10 +37,10 @@ def deeply_nested_props
       nested: {
         first: 'first nested param',
         second: 'second nested param',
-        evaluated: -> do
+        evaluated: lambda do
           {
             first: 'first evaluated nested param',
-            second: 'second evaluated nested param'
+            second: 'second evaluated nested param',
           }
         end,
         deeply_nested: {
@@ -48,10 +49,10 @@ def deeply_nested_props
           what_about_nil: nil,
           what_about_empty_hash: {},
           deeply_nested_always: InertiaRails.always { 'deeply nested always prop' },
-          deeply_nested_lazy: InertiaRails.lazy { 'deeply nested lazy prop' }
-        }
+          deeply_nested_lazy: InertiaRails.lazy { 'deeply nested lazy prop' },
+        },
       },
-      always: InertiaRails.always { 'always prop' }
+      always: InertiaRails.always { 'always prop' },
     }
   end
 
@@ -79,7 +80,7 @@ def lazy_props
       level: InertiaRails.lazy do
         'worse than he believes'
       end,
-      grit: InertiaRails.lazy(->{ 'intense' })
+      grit: InertiaRails.lazy(-> { 'intense' }),
     }
   end
 
@@ -98,17 +99,17 @@ def always_props
       optional: InertiaRails.optional do
         'optional prop'
       end,
-      another_optional: InertiaRails.optional { 'another optional prop' }
+      another_optional: InertiaRails.optional { 'another optional prop' },
     }
   end
 
   def merge_props
     render inertia: 'TestComponent', props: {
       merge: InertiaRails.merge { 'merge prop' },
-      deep_merge: InertiaRails.deep_merge { {deep: 'merge prop'} },
+      deep_merge: InertiaRails.deep_merge { { deep: 'merge prop' } },
       regular: 'regular prop',
       deferred_merge: InertiaRails.defer(merge: true) { 'deferred and merge prop' },
-      deferred_deep_merge: InertiaRails.defer(deep_merge: true) { {deep: 'deferred and merge prop'} },
+      deferred_deep_merge: InertiaRails.defer(deep_merge: true) { { deep: 'deferred and merge prop' } },
       deferred: InertiaRails.defer { 'deferred' },
     }
   end
@@ -120,7 +121,7 @@ def deferred_props
       level: InertiaRails.defer do
         'worse than he believes'
       end,
-      grit: InertiaRails.defer { 'intense' }
+      grit: InertiaRails.defer { 'intense' },
     }
   end
 end

Diff for: spec/inertia/rendering_spec.rb

@@ -83,39 +83,56 @@
     end
 
     context 'with a default component' do
-      let(:page) { InertiaRails::Renderer.new('inertia_route_with_default_component', controller, request, response, '').send(:page) }
+      let(:page) do
+        InertiaRails::Renderer.new('inertia_route_with_default_component', controller, request, response,
+                                   '').send(:page)
+      end
 
       before { get inertia_route_with_default_component_path }
 
       it { is_expected.to include inertia_div(page) }
     end
 
     context 'with a default component resource' do
-      let(:page) { InertiaRails::Renderer.new('items/inertia_route_with_default_component', controller, request, response, '').send(:page) }
+      let(:page) do
+        InertiaRails::Renderer.new('items/inertia_route_with_default_component', controller, request, response,
+                                   '').send(:page)
+      end
 
       before { get item_inertia_route_with_default_component_path(item_id: 1) }
 
       it { is_expected.to include inertia_div(page) }
     end
 
     context 'with a default component resource on member' do
-      let(:page) { InertiaRails::Renderer.new('items/inertia_route_with_default_component_on_member', controller, request, response, '').send(:page) }
+      let(:page) do
+        InertiaRails::Renderer.new(
+          'items/inertia_route_with_default_component_on_member', controller, request, response, ''
+        ).send(:page)
+      end
 
       before { get inertia_route_with_default_component_on_member_item_path(id: 1) }
 
       it { is_expected.to include inertia_div(page) }
     end
 
     context 'with a default component resource on collection' do
-      let(:page) { InertiaRails::Renderer.new('items/inertia_route_with_default_component_on_collection', controller, request, response, '').send(:page) }
+      let(:page) do
+        InertiaRails::Renderer.new(
+          'items/inertia_route_with_default_component_on_collection', controller, request, response, ''
+        ).send(:page)
+      end
 
       before { get inertia_route_with_default_component_on_collection_items_path }
 
       it { is_expected.to include inertia_div(page) }
     end
 
     context 'with a default component resource & scoped' do
-      let(:page) { InertiaRails::Renderer.new('items/inertia_route_with_default_component', controller, request, response, '').send(:page) }
+      let(:page) do
+        InertiaRails::Renderer.new('items/inertia_route_with_default_component', controller, request, response,
+                                   '').send(:page)
+      end
 
       before { get scoped_item_inertia_route_with_default_component_path(item_id: 1) }
 
@@ -513,7 +530,8 @@
     before { get merge_props_path, headers: headers }
 
     it 'returns non-optional props and meta on first load' do
-      expect(response.parsed_body['props']).to eq('merge' => 'merge prop', 'deep_merge' => { 'deep' => 'merge prop' }, 'regular' => 'regular prop')
+      expect(response.parsed_body['props']).to eq('merge' => 'merge prop', 'deep_merge' => { 'deep' => 'merge prop' },
+                                                  'regular' => 'regular prop')
       expect(response.parsed_body['mergeProps']).to match_array(%w[merge deferred_merge])
       expect(response.parsed_body['deepMergeProps']).to match_array(%w[deep_merge deferred_deep_merge])
       expect(response.parsed_body['deferredProps']).to eq('default' => %w[deferred_merge deferred_deep_merge deferred])
@@ -529,7 +547,10 @@
       end
 
       it 'returns listed and merge props' do
-        expect(response.parsed_body['props']).to eq({ 'deferred_merge' => 'deferred and merge prop', 'deferred_deep_merge' => { 'deep' => 'deferred and merge prop' } })
+        expect(response.parsed_body['props']).to eq(
+          'deferred_merge' => 'deferred and merge prop',
+          'deferred_deep_merge' => { 'deep' => 'deferred and merge prop' }
+        )
         expect(response.parsed_body['mergeProps']).to match_array(%w[merge deferred_merge])
         expect(response.parsed_body['deepMergeProps']).to match_array(%w[deep_merge deferred_deep_merge])
         expect(response.parsed_body['deferredProps']).to be_nil
@@ -547,7 +568,10 @@
       end
 
       it 'returns listed and merge props' do
-        expect(response.parsed_body['props']).to eq({ 'deferred_merge' => 'deferred and merge prop', 'deferred_deep_merge' => { 'deep' => 'deferred and merge prop' } })
+        expect(response.parsed_body['props']).to eq(
+          'deferred_merge' => 'deferred and merge prop',
+          'deferred_deep_merge' => { 'deep' => 'deferred and merge prop' }
+        )
         expect(response.parsed_body['mergeProps']).to match_array(%w[merge])
         expect(response.parsed_body['deferredProps']).to be_nil
       end