Skip to content

[BUGFIX] Support multiple values in SelectViewHelper #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[BUGFIX] Support multiple values in SelectViewHelper #664

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Classes/ViewHelpers/Form/SelectViewHelper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class SelectViewHelper extends AbstractFormFieldViewHelper
public function initialize(): void
{
parent::initialize();
$this->tag->addAttribute('data-selected-value', $this->getSelectedValue());
$this->tag->addAttribute('data-selected-value', is_array($this->getSelectedValue()) ? implode(',', $this->getSelectedValue()) : $this->getSelectedValue());
}

public function initializeArguments(): void
Expand Down Expand Up @@ -313,7 +313,6 @@ protected function isSelected(mixed $value): bool
*/
protected function getSelectedValue()
{
$selectedValues = null;
$this->setRespectSubmittedDataValue(true);
$value = $this->getValueAttribute();
if (!is_array($value) && !$value instanceof \Traversable) {
Expand All @@ -322,6 +321,10 @@ protected function getSelectedValue()
return $selectedValues;
}
}
$selectedValues = [];
foreach ($value as $selectedValueElement) {
$selectedValues[] = $this->getOptionValueScalar($selectedValueElement);
}

// set preselection from TypoScript
if (! $this->renderingContext instanceof RenderingContext) {
Expand Down