Skip to content

Commit d08cf3a

Browse files
committed
Fix issues discovered by TypeScript
build passes now
1 parent 530a653 commit d08cf3a

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/es5.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
import {
55
is,
66
isProxyable,
7-
isProxy,
87
PROXY_STATE,
98
shallowCopy,
109
RETURNED_AND_MODIFIED_ERROR,
10+
has,
1111
each,
1212
finalize
1313
} from "./common"
@@ -191,10 +191,7 @@ function shallowEqual(objA, objB) {
191191
const keysB = Object.keys(objB)
192192
if (keysA.length !== keysB.length) return false
193193
for (let i = 0; i < keysA.length; i++) {
194-
if (
195-
!hasOwnProperty.call(objB, keysA[i]) ||
196-
!is(objA[keysA[i]], objB[keysA[i]])
197-
) {
194+
if (!has(objB, keysA[i]) || !is(objA[keysA[i]], objB[keysA[i]])) {
198195
return false
199196
}
200197
}

src/proxy.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ const objectTraps = {
2727
deleteProperty,
2828
getOwnPropertyDescriptor,
2929
defineProperty,
30-
setPrototypeOf() {
30+
setPrototypeOf(): never {
3131
throw new Error("Don't even try this...")
3232
}
3333
}
@@ -102,7 +102,7 @@ function getOwnPropertyDescriptor(state, prop) {
102102
return descriptor
103103
}
104104

105-
function defineProperty() {
105+
function defineProperty(): never {
106106
throw new Error(
107107
"Immer does currently not support defining properties on draft objects"
108108
)

0 commit comments

Comments
 (0)