Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Backend validation to catch empty caseids in the HL7v2 patient information retrievers #167

Open
ywarnecke opened this issue Jan 27, 2025 · 0 comments · May be fixed by #175
Open

Add Backend validation to catch empty caseids in the HL7v2 patient information retrievers #167

ywarnecke opened this issue Jan 27, 2025 · 0 comments · May be fixed by #175
Assignees
@hussainsabir52
Labels
bug Something isn't working
Milestone
MoPat v3.2.1

Comments

@ywarnecke
Copy link
Member

Apparently on some devices the frontend validation is not working correctly:

Message: An internal server error on page /mobile/survey/bundles occured. Please check the server log Exception: java.lang.NullPointerException: Cannot invoke "String.trim()" because "caseNumber" is null at de.imi.mopat.helper.controller.HL7v22PatientInformationRetriever.retrievePatientData(HL7v22PatientInformationRetriever.java:75)

This should be easily fixable by adding a validation check here.

It also should be added for the HL7v22PatientInformationRetrieverByPID class.
@ywarnecke ywarnecke added the bug Something isn't working label Jan 27, 2025
@ywarnecke ywarnecke added this to the MoPat v3.2.1 milestone Jan 27, 2025
@hussainsabir52 hussainsabir52 self-assigned this Jan 30, 2025
@hussainsabir52 hussainsabir52 linked a pull request Jan 30, 2025 that will close this issue
Open
@hussainsabir52 hussainsabir52 linked a pull request Jan 30, 2025 that will close this issue
Null check for caseNumber and patientNumber for HL7 patient data retriever #175
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hussainsabir52 hussainsabir52

Labels
bug Something isn't working
Projects
None yet
Milestone
MoPat v3.2.1
Development

Successfully merging a pull request may close this issue.

Null check for caseNumber and patientNumber for HL7 patient data retriever imi-ms/MoPat
2 participants
@hussainsabir52 @ywarnecke