chore: enable unicorn ESLint config (#329)

Author: targos

.eslintrc.yml

@@ -1,6 +1,10 @@
 root: true
-extends: [cheminfo-typescript, cheminfo-typescript/jsdoc]
-plugins: [jest]
+extends:
+  - cheminfo-typescript
+  - cheminfo-typescript/jsdoc
+  - cheminfo-typescript/unicorn
+plugins:
+  - jest
 rules:
   '@typescript-eslint/restrict-template-expressions': off
   'jest/no-focused-tests': 'error'

src/featureMatching/descriptors/getBriefDescriptors.ts

@@ -94,7 +94,7 @@ export function getBriefDescriptors(
     let patch: Image;
     try {
       patch = getKeypointPatch(smoothed, keypoint, { patchSize });
-    } catch (err) {
+    } catch {
       continue;
     }
     if (patch === null) continue;

src/roi/Roi.ts

@@ -237,8 +237,8 @@ export class Roi {
       let two = 0;
       let three = 0;
       let four = 0;
-      let externalIDs = this.externalBorders.map(
-        (element) => element.connectedID,
+      let externalIDs = new Set(
+        this.externalBorders.map((element) => element.connectedID),
       );
       for (let column = 0; column < this.width; column++) {
         for (let row = 0; row < this.height; row++) {
@@ -247,25 +247,25 @@ export class Roi {
             let nbAround = 0;
             if (column === 0) {
               nbAround++;
-            } else if (externalIDs.includes(data[target - 1])) {
+            } else if (externalIDs.has(data[target - 1])) {
               nbAround++;
             }
 
             if (column === roiMap.width - 1) {
               nbAround++;
-            } else if (externalIDs.includes(data[target + 1])) {
+            } else if (externalIDs.has(data[target + 1])) {
               nbAround++;
             }
 
             if (row === 0) {
               nbAround++;
-            } else if (externalIDs.includes(data[target - roiMap.width])) {
+            } else if (externalIDs.has(data[target - roiMap.width])) {
               nbAround++;
             }
 
             if (row === roiMap.height - 1) {
               nbAround++;
-            } else if (externalIDs.includes(data[target + roiMap.width])) {
+            } else if (externalIDs.has(data[target + roiMap.width])) {
               nbAround++;
             }
             switch (nbAround) {

src/roi/__tests__/ellipse.test.ts

@@ -14,21 +14,21 @@ test('ellipse on a small figure 3x3', () => {
     center: { column: 1, row: 1 },
     majorAxis: {
       points: [
-        { column: NaN, row: Infinity },
-        { column: NaN, row: -Infinity },
+        { column: Number.NaN, row: Number.POSITIVE_INFINITY },
+        { column: Number.NaN, row: Number.NEGATIVE_INFINITY },
       ],
-      length: Infinity,
-      angle: NaN,
+      length: Number.POSITIVE_INFINITY,
+      angle: Number.NaN,
     },
     minorAxis: {
       points: [
-        { column: NaN, row: NaN },
-        { column: NaN, row: NaN },
+        { column: Number.NaN, row: Number.NaN },
+        { column: Number.NaN, row: Number.NaN },
       ],
-      length: NaN,
-      angle: NaN,
+      length: Number.NaN,
+      angle: Number.NaN,
     },
-    surface: NaN,
+    surface: Number.NaN,
   });
 });
 test('ellipse on a small figure 3x3', () => {

src/utils/geometry/getCirclePoints.ts

@@ -33,16 +33,18 @@ export function getCirclePoints(radius: number): Point[] {
   return firstQuarter.concat(secondQuarter, thirdQuarter, fourthQuarter);
 }
 
+const zeroPoint: Point = { row: 0, column: 0 };
+
 /**
  * Get the coordinates of the points in a circle of given radius. The points are sorted by column then row.
  *
  * @param radius - Radius of the circle.
- * @param center - Center of the cirlce.
+ * @param center - Center of the circle.
  * @returns The coordinates of the points in a circle of given radius.
  */
 export function getFilledCirclePoints(
   radius: number,
-  center: Point = { column: 0, row: 0 },
+  center: Point = zeroPoint,
 ): Point[] {
   let circlePoints: Point[] = [];