Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search at /list/nonwg is frustrating #3675

Closed
rjsparks opened this issue Mar 18, 2022 · 11 comments · Fixed by #4266
Closed

Search at /list/nonwg is frustrating #3675

rjsparks opened this issue Mar 18, 2022 · 11 comments · Fixed by #4266

Comments

@rjsparks
Copy link
Member

The search widget for this page will not let me find the lists ending with -ag.
That might be more important on other pages where the widget is used - it's just an annoyance here.

@rjsparks rjsparks added trivial bs5 Bootstrap 5 facelift labels Mar 18, 2022
@russhousley
Copy link
Collaborator

The list contains things that do not belong. For example, 'geopriv' is listed as a non-wg list, but it is a concluded wg. Maybe this should be a separate issue.

@larseggert
Copy link
Collaborator

The search issue seems to be due to javve/list.js#699. I'm checking what can be done.

@rjsparks rjsparks removed the bs5 Bootstrap 5 facelift label Apr 6, 2022
@rjsparks
Copy link
Member Author

rjsparks commented Apr 6, 2022

This should only be addressed in bootstrap5, but it can wait until after that is part of main

@rjsparks
Copy link
Member Author

This is still in need of improvement. Example - use the search box to find the genart list...

@larseggert
Copy link
Collaborator

This is because javve/list.js#699 is still not merged.

@rjsparks
Copy link
Member Author

So, that project hasn't had a commit since Jan 2021. Do we start maintaining our own fork, or can we find a replacement for the library that is actively maintained?

@larseggert
Copy link
Collaborator

Yeah, sorry about picking this. When I started the bs5 work, Jan 2021 was not that far away, but now it is.

Don't we have the ability to monkey-patch things, or does that only work for python?

@rjsparks
Copy link
Member Author

It's only python, and the fragility of monkey-patch approach has always bothered me.

@larseggert
Copy link
Collaborator

Then we should fork, or maybe @NGPixel has a vue thing that could replace it?

@NGPixel
Copy link
Member

NGPixel commented Jul 22, 2022

If we're going through the trouble of forking, patching and publishing our modified version of the library, it might indeed be worth rewriting the page in Vue (which can easily replicate this functionality, without the need for libraries).

@larseggert
Copy link
Collaborator

It's not just one page, it's all the search and sort stuff for all tables.

@larseggert larseggert moved this to Todo in Codesprint 114 Jul 23, 2022
larseggert added a commit to larseggert/datatracker that referenced this issue Jul 24, 2022
Fixes ietf-tools#3675

@rjsparks, this avoids us needing to fork list.js. If you prefer a fork, let me
know.
larseggert added a commit to larseggert/datatracker that referenced this issue Jul 24, 2022
Fixes ietf-tools#3675

@rjsparks, this avoids us needing to fork list.js. If you prefer a fork, let me
know.
rjsparks pushed a commit that referenced this issue Jul 26, 2022
* fix: Allow searching for non-alphanumeric characters

Fixes #3675

@rjsparks, this avoids us needing to fork list.js. If you prefer a fork, let me
know.

* Add a TODO
Repository owner moved this from Todo to Done in Codesprint 114 Jul 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants