Skip to content

Commit a41faa4

Browse files
committed
Improve code quality
1 parent d8ecb0d commit a41faa4

File tree

2 files changed

+28
-28
lines changed

2 files changed

+28
-28
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
55
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
66

7-
## [0.1.0] - 2020-11-05
7+
## **0.1.0** - 2020-11-05
88

99
### Added
10-
- Basic input and output handling for grid models provided by csv files following the specifications of [PowerSystemDataModel](https://raw.githubusercontent.com/ie3-institute/PowerSystemDataModel) - up to version XXX
10+
- Basic input and output handling for grid models provided by csv files following the specifications of [PowerSystemDataModel](https://raw.githubusercontent.com/ie3-institute/PowerSystemDataModel) - up to version 1.3.2
1111
- Visualisation of the grid model including system participants (e.g. loads, pv plants, ...)
1212
- Basic editing functionality (Renaming, moving around nodes to alter their geographical position, ...)

CONTRIBUTING.md

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,14 @@ And thank you for considering your contribution to this project!
44
With this document we would like to give you some orientation on how you can contribute.
55

66
## Table of contents
7-
* [Testing and reporting bugs](#testing-and-reporting-bugs)
8-
* [Suggest extensions](#suggest-extensions)
9-
* [Contributing code](#contributing-code)
10-
* [Branching and handing in pull requests](#branching-and-handing-in-pull-requests)
11-
* [General (software) design guidelines](#general-software-design-guidelines)
12-
* [Testing](#testing)
13-
* [Finalising your pull request](#finalising-your-pull-request)
14-
* [For any doubts](#for-any-doubts)
7+
* [Testing and reporting bugs](#testing-and-reporting-bugs)
8+
* [Suggest extensions](#suggest-extensions)
9+
* [Contributing code](#contributing-code)
10+
* [Branching and handing in pull requests](#branching-and-handing-in-pull-requests)
11+
* [General (software) design guidelines](#general-software-design-guidelines)
12+
* [Testing](#testing)
13+
* [Finalising your pull request](#finalising-your-pull-request)
14+
* [For any doubts](#for-any-doubts)
1515

1616
## Testing and reporting bugs
1717
We really appreciate your usage of this project.
@@ -20,22 +20,22 @@ Until now we have a good lack of high level documentation, therefore please chec
2020
If not, please raise one for us.
2121
Considering the following aspects in your inquiry, assists us in helping you:
2222

23-
* **Is there already an issue addressing your problem?**
24-
* Try to **locate the error** as precise as possible.
25-
* What has to be done to **reproduce the error**?
26-
* **Provide stack trace, logs etc.** and further helpful information
27-
* **What would do you expect to happen?**
28-
* Mark the issue with the **label _bug_**.
23+
* **Is there already an issue addressing your problem?**
24+
* Try to **locate the error** as precise as possible.
25+
* What has to be done to **reproduce the error**?
26+
* **Provide stack trace, logs etc.** and further helpful information
27+
* **What would do you expect to happen?**
28+
* Mark the issue with the **label _bug_**.
2929

3030
## Suggest extensions
3131
We use issues as well to keep track of enhancement suggestions.
3232
Considering the following aspects, assists us in understanding your needs properly:
3333

34-
* **Is there already an issue addressing your request?**
35-
* **What would do you desire for?**
36-
* If possible provide an **example or sketch**.
37-
* Show a **use case**, that should be as versatile as possible.
38-
* Mark the issue with the **label _enhancement_**.
34+
* **Is there already an issue addressing your request?**
35+
* **What would do you desire for?**
36+
* If possible provide an **example or sketch**.
37+
* Show a **use case**, that should be as versatile as possible.
38+
* Mark the issue with the **label _enhancement_**.
3939

4040
## Contributing code
4141
If you intend to produce some lines of code, pick an issue and get some hands on!
@@ -49,9 +49,9 @@ Before opening it for review, please [finalise your pull request](#finalising-yo
4949
### General (software) design guidelines
5050
In order to maintain a consistent project, we thought of some general design guidlines, we kindly ask you to take care of:
5151

52-
* We :heart: **immutability**. Therefore, please don't provide setters and use proper instantiation instead.
53-
* `double a = b * pow(x, j)`? :hand: Please **be expressive** in what you code!
54-
* Document your code with **javadoc**.
52+
* We :heart: **immutability**. Therefore, please don't provide setters and use proper instantiation instead.
53+
* `double a = b * pow(x, j)`? :hand: Please **be expressive** in what you code!
54+
* Document your code with **javadoc**.
5555

5656
### Testing
5757
Ensure the proper function of your code by [test driven development (TDD)](https://www.guru99.com/test-driven-development.html).
@@ -61,14 +61,14 @@ We have good experiences using [Spock](http://spockframework.org/) as a testing
6161
Some automated checks assist us in delivering a pretty fair quality of software.
6262
Before marking the pull request as 'ready to review', take these precautionary actions:
6363

64-
* Are all tests passing? Run `gradle test`
65-
* Is your code properly formatted? Run `gradle spotlessApply`
64+
* Are all tests passing? Run `gradle test`
65+
* Is your code properly formatted? Run `gradle spotlessApply`
6666

6767
`gradle finalizePR` summarizes all of these steps .
6868

6969
## For any doubts
7070
... please contact
71-
* [Johannes (@johanneshiry)](https://github.com/johanneshiry) or
72-
* [Chris (@ckittl)](https://github.com/ckittl)
71+
* [Johannes (@johanneshiry)](https://github.com/johanneshiry) or
72+
* [Chris (@ckittl)](https://github.com/ckittl)
7373

7474
We are happy to help! :smiley:

0 commit comments

Comments
 (0)