Fxed issue: Favicon not showing in the browser tab #1209 #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1209
Title: Fix: Update Favicon Path and Resolution for Consistent Deployment Behavior
Description:
Issue: The favicon was appearing blank in the deployed version of the application, even though it displayed correctly locally.
Root Cause: An investigation revealed that the favicon reference was commented out in the production HTML. Additionally, the favicon file was not located in the public folder, which is required for proper asset serving in Vite-based projects.
Fix Implemented:
Uncommented the <link rel="icon" ...> tag.
Moved the favicon.ico file to the public folder to ensure it is served from the root (/favicon.ico).
Adjusted the resolution of the favicon to improve compatibility across different browsers.
Testing: The changes have been verified on Safari, Microsoft Edge, and Arc. Note that Brave may have caching issues; a hard refresh or cache clear might be necessary.
Rationale:
Keeping the favicon in the public folder guarantees that it is accessible at the root URL, as expected by browsers. This eliminates path resolution issues and ensures that the favicon is consistently loaded in both development and production environments.