Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USE_IGNORE_SEGMENT_ENDINGS = True fails in this simple case #27

Open
smldis opened this issue Jun 8, 2022 · 0 comments
Open

USE_IGNORE_SEGMENT_ENDINGS = True fails in this simple case #27

smldis opened this issue Jun 8, 2022 · 0 comments

Comments

@smldis
Copy link

smldis commented Jun 8, 2022

USE_IGNORE_SEGMENT_ENDINGS = True fails in this case with a false positive (related to handling of floating point precision)

Runnable code:

segments = [((1244.1140298175264, 880.2941002930444),(1243.2055718759748, 880.4612970469328)),
            ((1243.2055718759748, 880.4612970469328),(1244.196882082508, 880.5928419990338))]
intersections = poly_point_isect.isect_segments_include_segments(segments)

Output:

[((1243.2055718761806, 880.4612970469013),
  [((1243.2055718759748, 880.4612970469328),
    (1244.196882082508, 880.5928419990338)),
   ((1243.2055718759748, 880.4612970469328),
    (1244.1140298175264, 880.2941002930444))])]

Expected Output is []

If I change NUM_EPS = Real("1e-10") to 1e-8 it works but I have no idea if I am breaking anything from doing that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant