Issue 122 Philips Multiframe dti with ADC #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_with_ADC Issue122 philips multiframe dti with adc
ma-tripleT
commented
May 13, 2025
| bvecs = None | ||
|
|
||
| return bvals, bvecs, bval_file, bvec_file | ||
| return nifti, bvals, bvecs, bval_file, bvec_file |
Author
There was a problem hiding this comment.
The key change - to return the modified nifti i.e. the ADC was removed a few lines earlier.
ma-tripleT
commented
May 13, 2025
| bvec_file = '%s/%s.bvec' % (base_path, base_name) | ||
| bval, bvec, bval_file, bvec_file = _create_bvals_bvecs(multiframe_dicom, bval_file, bvec_file, nii_image, | ||
| output_file) | ||
| nii_image, bval, bvec, bval_file, bvec_file = _create_bvals_bvecs( |
Author
There was a problem hiding this comment.
Including the nii_image in the tuple of variables to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A two-variable fix for #122
Ensuring that _is_multiframe_diffusion_imaging() actually returns the modified NIfTI (after ADC is removed) then handling this extra return in the Tuple.
With new test data too.