Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create only one certificate per domain for multiple routes with same domain #14

Open
mguillem opened this issue Apr 27, 2017 · 6 comments

Comments

@mguillem
Copy link
Contributor

According to the log (and my understanding of the code), it seems that a new certificate is requested for each route, even if the host name is the same. This is a problem due to the rate limit of letsencrypt.

In our case, multiple routes are used to map different services to sub paths.

@ibotty
Copy link
Owner

ibotty commented Apr 27, 2017 via email

@ibotty
Copy link
Owner

ibotty commented Apr 27, 2017

Oh, you mean routes with paths. Yeah, that's a bug, I introduced when going from secrets to just storing the certificates in the route.

@mguillem
Copy link
Contributor Author

What was the motivation for moving away from the secrets?

@ibotty
Copy link
Owner

ibotty commented Apr 27, 2017 via email

@ibotty
Copy link
Owner

ibotty commented Apr 28, 2017

I don't have much time now, can you please test the path-routes branch? It should fix that part (and lay the foundation of grouping certificates).

@ibotty
Copy link
Owner

ibotty commented Jun 13, 2017

Did you have a chance to test the branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants