-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create only one certificate per domain for multiple routes with same domain #14
Comments
Yes, that's right. Any idea how an api should look like? I prefer being explicit which domains to combine.
|
Oh, you mean routes with paths. Yeah, that's a bug, I introduced when going from secrets to just storing the certificates in the route. |
What was the motivation for moving away from the secrets? |
It did not work for some people, I guess because of bugs in openshift.
Additionally, having the certificates in two places (the route and
a secret) is not nice. I really do hope, that routes when they get
rebased on top of ingresses additionally have a way to reference
a secret.
|
I don't have much time now, can you please test the path-routes branch? It should fix that part (and lay the foundation of grouping certificates). |
Did you have a chance to test the branch? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to the log (and my understanding of the code), it seems that a new certificate is requested for each route, even if the host name is the same. This is a problem due to the rate limit of letsencrypt.
In our case, multiple routes are used to map different services to sub paths.
The text was updated successfully, but these errors were encountered: