Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated: map.prompt.room ??? #46

Open
iLPdev opened this issue Jun 25, 2020 · 2 comments
Open

Deprecated: map.prompt.room ??? #46

iLPdev opened this issue Jun 25, 2020 · 2 comments
Labels
question Further information is requested

Comments

@iLPdev
Copy link
Owner

iLPdev commented Jun 25, 2020

Should we go through and replace map.prompt.room with gmcp.room.info.name everywhere or define it once and for all at the beginning? It's not a local variable so the user can alter it as intended, but would there ever be a reason to do so? discMapper sets the room name based on what the game sends rather than misidentified text or location as previously.

@iLPdev iLPdev added the question Further information is requested label Jun 25, 2020
@iLPdev iLPdev changed the title map.prompt.room deprecated? deprecated: map.prompt.room Jun 25, 2020
@iLPdev iLPdev changed the title deprecated: map.prompt.room Deprecated: map.prompt.room Jun 25, 2020
@iLPdev
Copy link
Owner Author

iLPdev commented Jun 25, 2020

maybe not. maybe this is the side route to getting the room name detection notice by the older parts of the script

i.e., map.prompt.room = gmcp.room.info.name as a part of onNewRoom event?

@iLPdev iLPdev changed the title Deprecated: map.prompt.room Deprecated: map.prompt.room ??? Jun 25, 2020
@iLPdev
Copy link
Owner Author

iLPdev commented Jul 8, 2020

I dunno. I left this in. It's a non-local variable that can be accessed external to the script. I'm not sure what use it might be in the future given that rooms are now GMCP-derived, but it seems like pretty negligible tech debt to leave in... or add back for that matter. Undecided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant