first version of the JSON schema. Fixes issue #27 #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psschwei
reviewed
Jan 23, 2025
|
See latest changes @akihikokuroda, @psschwei, and @planetf1 Let's merge, if OK, since I have new version for conditionals |
|
Other than the last comment. It looks good to me. Thanks! |
|
OK. Addressed. Resolving all issues. |
|
OK. We are good for a merge here @akihikokuroda or others. Thx |
|
Closes issue #132 |
psschwei
reviewed
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple JSON workflow that adds the basic workflow features in RC0. One addition is the definition of the "exception" step.
There are two test files in
test/schmas/simple.<yml|json>Plan is to have tests for issue #132 that will use this file.
You can manually verify the sample tests files using: https://jsonschema.dev
JSON to YAML conversion can be done easily with
jsonandyamllibraries or using: https://www.bairesdev.com/tools/json2yaml/ or similar toolCC: @akihikokuroda @psschwei please do a quick review and merge so I can push the CLI code. Thx