Make annotation cards focusable #7334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
force-pushed
the
sidebar-panel-trigger-titles
branch
from
c3ff4c6 to
9bea91d
Compare
acelaya
commented
Sep 23, 2025
| data-testid="thread-card" | ||
| elementRef={cardRef} | ||
| tabIndex={-1} | ||
| tabIndex={0} |
Contributor
Author
There was a problem hiding this comment.
Make the element focusable, and be part of the regular tab sequence.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7334 +/- ##
==========================================
- Coverage 99.47% 99.41% -0.06%
==========================================
Files 271 271
Lines 10968 10974 +6
Branches 2620 2624 +4
==========================================
Hits 10910 10910
- Misses 58 64 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acelaya
commented
Sep 23, 2025
| elementRef={cardRef} | ||
| tabIndex={-1} | ||
| tabIndex={0} | ||
| role="article" |
Contributor
Author
There was a problem hiding this comment.
TBD if article is the right role here.
acelaya
force-pushed
the
sidebar-panel-trigger-titles
branch
from
9bea91d to
acd3176
Compare
Contributor
Author
|
Superseded by #7339, as the branch name here is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6306
This PR brings back the changes from #5539 and #5570, that we then had to roll back because of the issues reported in https://github.com/hypothesis/support/issues/31
However, by implementing this again I cannot reproduce any of those issues anymore. Since the event handler ignores events not targeting the card itself, it should not be triggered while editing an annotation or interacting with other child controls.
TODO
button, but I was never 100% sure about that.Bluesky uses
linkrole for their posts in the feed, but we don't link anywhere from an anno card.Twitter uses
article, which is what I provisionally used here.The regular tab sequence has a lot of elements, making it odd to move the focus between cards.