Skip to content

Commit 711ea65

Browse files
chore: make rx support a little nicer and upgrade grpc (#11)
1 parent 65a2fb0 commit 711ea65

File tree

6 files changed

+25
-10
lines changed

6 files changed

+25
-10
lines changed

grpc-client-rx-utils/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@ plugins {
77

88
dependencies {
99
api("io.reactivex.rxjava3:rxjava:3.0.6")
10-
api("io.grpc:grpc-stub:1.35.0")
10+
api("io.grpc:grpc-stub:1.36.0")
1111
api(project(":grpc-context-utils"))
12-
implementation("io.grpc:grpc-context:1.35.0")
12+
implementation("io.grpc:grpc-context:1.36.0")
1313

1414
testImplementation("org.junit.jupiter:junit-jupiter:5.7.0")
1515
testImplementation("org.mockito:mockito-core:3.5.11")

grpc-client-utils/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ dependencies {
1313
// End Logging
1414

1515
// grpc
16-
implementation("io.grpc:grpc-core:1.35.0")
16+
implementation("io.grpc:grpc-core:1.36.0")
1717
constraints {
1818
implementation("com.google.guava:guava:30.0-jre") {
1919
because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415")

grpc-context-utils/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ tasks.test {
1111

1212
dependencies {
1313
// grpc
14-
implementation("io.grpc:grpc-core:1.35.0")
14+
implementation("io.grpc:grpc-core:1.36.0")
1515
constraints {
1616
implementation("com.google.guava:guava:30.0-jre") {
1717
because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415")

grpc-server-rx-utils/build.gradle.kts

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,18 @@ plugins {
77

88
dependencies {
99
api("io.reactivex.rxjava3:rxjava:3.0.6")
10-
api("io.grpc:grpc-stub:1.35.0")
10+
api("io.grpc:grpc-stub:1.36.0")
11+
12+
annotationProcessor("org.projectlombok:lombok:1.18.18")
13+
compileOnly("org.projectlombok:lombok:1.18.18")
14+
15+
implementation("org.slf4j:slf4j-api:1.7.30")
16+
1117
constraints {
12-
implementation("com.google.guava:guava:30.0-jre") {
18+
implementation("com.google.guava:guava:30.1-jre") {
1319
because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415")
1420
}
1521
}
16-
1722
testImplementation("org.junit.jupiter:junit-jupiter:5.7.0")
1823
testImplementation("org.mockito:mockito-core:3.5.11")
1924
testImplementation("org.mockito:mockito-junit-jupiter:3.5.11")

grpc-server-rx-utils/src/main/java/org/hypertrace/core/grpcutils/server/rx/ServerCallStreamRxObserver.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,29 @@
11
package org.hypertrace.core.grpcutils.server.rx;
22

33
import io.grpc.stub.ServerCallStreamObserver;
4+
import io.grpc.stub.StreamObserver;
45
import io.reactivex.rxjava3.annotations.NonNull;
56
import io.reactivex.rxjava3.core.CompletableObserver;
67
import io.reactivex.rxjava3.core.MaybeObserver;
78
import io.reactivex.rxjava3.core.Observer;
89
import io.reactivex.rxjava3.core.SingleObserver;
910
import io.reactivex.rxjava3.observers.DefaultObserver;
11+
import lombok.extern.slf4j.Slf4j;
1012

13+
@Slf4j
1114
public class ServerCallStreamRxObserver<T> extends DefaultObserver<T>
1215
implements Observer<T>, MaybeObserver<T>, SingleObserver<T>, CompletableObserver {
1316

1417
private final ServerCallStreamObserver<T> serverCallStreamObserver;
1518

16-
public ServerCallStreamRxObserver(ServerCallStreamObserver<T> serverCallStreamObserver) {
17-
this.serverCallStreamObserver = serverCallStreamObserver;
19+
/**
20+
* Requires a ServerCallStreamObserver which a grpc server implementation will provide (but not
21+
* specify)
22+
*
23+
* @param serverCallStreamObserver
24+
*/
25+
public ServerCallStreamRxObserver(StreamObserver<T> serverCallStreamObserver) {
26+
this.serverCallStreamObserver = (ServerCallStreamObserver<T>) serverCallStreamObserver;
1827
}
1928

2029
@Override
@@ -35,6 +44,7 @@ public void onNext(@NonNull T value) {
3544

3645
@Override
3746
public void onError(@NonNull Throwable throwable) {
47+
log.error("Returning error", throwable);
3848
this.serverCallStreamObserver.onError(throwable);
3949
}
4050

grpc-server-utils/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ dependencies {
1717
// End Logging
1818

1919
// grpc
20-
implementation("io.grpc:grpc-core:1.35.0")
20+
implementation("io.grpc:grpc-core:1.36.0")
2121
constraints {
2222
implementation("com.google.guava:guava:30.0-jre") {
2323
because("https://snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-1015415")

0 commit comments

Comments
 (0)