Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define support for repeated fields in env vars #32

Open
jcchavezs opened this issue Nov 26, 2020 · 4 comments
Open

Define support for repeated fields in env vars #32

jcchavezs opened this issue Nov 26, 2020 · 4 comments

Comments

@jcchavezs
Copy link
Contributor

Right now our env vars don't support repeated fields (aka arrays), we should define if we are going to support them and the way to do it. We could settle on only support repeated for scalar types (e.g. string, bool, enums) because representing objects will be very cumbersome.

Some examples in https://github.com/hypertrace/agent-config/blob/main/config.proto#L26 are:

  • HT_PROPAGATION_FORMATS=B3,TRACE_CONTEXT
  • HT_PROPAGATION_FORMATS=B3|TRACE_CONTEXT
  • HT_PROPAGATION_FORMATS=B3;TRACE_CONTEXT

Ping @hypertrace/agent-maintainers
@mohit-a21
Copy link
Contributor

I agree that we should only support env vars for scalar types only. HT_PROPAGATION_FORMATS=B3,TRACE_CONTEXT For me, I would go for this format.

@davexroth
Copy link

, works for me.

@jcchavezs
Copy link
Contributor Author

any thoughts @pavolloffay ?

@pavolloffay
Copy link
Member

HT_PROPAGATION_FORMATS=B3,TRACE_CONTEXT looks the most natural for me

@mohit-a21 mohit-a21 mentioned this issue Jan 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcchavezs @pavolloffay @davexroth @mohit-a21