Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review unsafe scopes #313

Open
dblnz opened this issue Mar 4, 2025 · 0 comments
Open

Review unsafe scopes #313

dblnz opened this issue Mar 4, 2025 · 0 comments
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. lifecycle/needs-review The issue has not yet been reviewed.
Milestone
Backlog

Comments

@dblnz
Copy link
Contributor

dblnz commented Mar 4, 2025

In general the use of unsafe should be limited to blocks where unsafe code is used , with the exception that public functions that dereference raw pointer arguments should be marked as unsafe see here.

We need to review the code base to use the smallest possible scopes.

This can be split into multiple smaller issues to address specific parts of the codebase.
@dblnz dblnz added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Mar 4, 2025
@github-actions github-actions bot added the lifecycle/needs-review The issue has not yet been reviewed. label Mar 4, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. lifecycle/needs-review The issue has not yet been reviewed.
Projects
Hyperlight Milestones
Status: No status
Milestone
Backlog
Development

No branches or pull requests
2 participants
@dblnz @danbugs