Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use println! macros in default host writer function to be able to capture output during tests #207

Open
ludfjig opened this issue Jan 29, 2025 · 0 comments
Labels
lifecycle/needs-review The issue has not yet been reviewed.
Milestone

Comments

@ludfjig
Copy link
Contributor

ludfjig commented Jan 29, 2025

When a guests prints, the host will print to terminal in green color using the termcolor crate. Since we don't use the println! macros for this, the stdout output is not captured by tests. I personally don't think the green color is enough to justify the different behavior from println! style macros, so I think we should switch it out. If we want, we could have a prefix instead, maybe something like [guest] hello world!.

@syntactically syntactically added the lifecycle/needs-review The issue has not yet been reviewed. label Feb 5, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/needs-review The issue has not yet been reviewed.
Projects
Status: No status
Development

No branches or pull requests

3 participants