Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Error handling between the guest and the host #203

Open
simongdavies opened this issue Jan 29, 2025 · 0 comments
Open

Improve Error handling between the guest and the host #203

simongdavies opened this issue Jan 29, 2025 · 0 comments
Labels
lifecycle/needs-review The issue has not yet been reviewed.
Milestone

Comments

@simongdavies
Copy link
Contributor

At present when raising an error in the guest we are using a generic HyperlightGuestError variant, it should be possible for a hyperlight implementation to define their own error variants.

These variants should be transparently translated between guest and host, in other words if a guest returns Err(ParseError) then the result of the call in the host should be Err(ParseError)

There are two parts to solving this issue:
(1) Being able to create specific types of Hyperlight guest errors (i.e., similar to thiserror in the host),
(2) Type information of the guest error in the host would get lost without (1).

Note that thiserror now supports no_std.

@simongdavies simongdavies added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Jan 29, 2025
@github-actions github-actions bot added the lifecycle/needs-review The issue has not yet been reviewed. label Jan 29, 2025
@syntactically syntactically removed the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Feb 5, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/needs-review The issue has not yet been reviewed.
Projects
Status: No status
Development

No branches or pull requests

3 participants