Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review code for use of expect()/unwrap()/panic!()/assert!() #196

Open
simongdavies opened this issue Jan 29, 2025 · 0 comments
Open

Review code for use of expect()/unwrap()/panic!()/assert!() #196

simongdavies opened this issue Jan 29, 2025 · 0 comments
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Milestone

Comments

@simongdavies
Copy link
Contributor

There are numerous places where we use either expect()/unwrap()/panic!()/assert!() we should review and remove these where possible as they will cause the host process to crash.

Consider adding the following clippy checks:

expect_used
panic
unwrap_used

We should also check for use of indexing like this function_call.parameters.clone().unwrap()[0].clone() without checking the number of items.

@simongdavies simongdavies added the kind/bugfix For PRs that fix bugs label Jan 29, 2025
@github-actions github-actions bot added the lifecycle/needs-review The issue has not yet been reviewed. label Jan 29, 2025
@syntactically syntactically added lifecycle/confirmed Bug is verified or proposal seems reasonable and removed kind/bugfix For PRs that fix bugs lifecycle/needs-review The issue has not yet been reviewed. labels Feb 5, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Projects
Status: No status
Development

No branches or pull requests

3 participants