Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weak Link a default implementation of c_guest_dispatch_function in hyperlight_guest_capi #195

Open
simongdavies opened this issue Jan 29, 2025 · 0 comments
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Milestone

Comments

@simongdavies
Copy link
Contributor

Implement a default implementation of hyperlight_guest_capi and then weak link it so a guest is not forced to provide a default implementation.

Since Rust weak linkage is an unstable feature, we should consider adding this as a C implementation with __attribute__((weak)) in the meantime.

See here

@simongdavies simongdavies added the kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. label Jan 29, 2025
@github-actions github-actions bot added the lifecycle/needs-review The issue has not yet been reviewed. label Jan 29, 2025
@syntactically syntactically added lifecycle/confirmed Bug is verified or proposal seems reasonable and removed kind/enhancement For PRs adding features, improving functionality, docs, tests, etc. lifecycle/needs-review The issue has not yet been reviewed. labels Feb 5, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Projects
Status: No status
Development

No branches or pull requests

3 participants