New issue

Jump to bottom

Investigate slow sandbox drop times #189

Open

ludfjig opened this issue Jan 29, 2025 · 0 comments

Labels

area/performance lifecycle/confirmed

Milestone

Contributor

ludfjig commented Jan 29, 2025

Drop times for sandboxes are currently pretty slow due to slow dropping of file descriptors.

Code comments suggests kvm's _vm_fd and _kvm are for livetime purposes, but it might be possible remove these (?). In any case, not every individual driver needs a fd to the kvm device.
We should investigate and see whether unmapping guest memory before calling munmap (this is currently done on mshv but not kvm).

github-actions bot added the lifecycle/needs-review label

syntactically added area/performance lifecycle/confirmed and removed lifecycle/needs-review labels

danbugs added this to Hyperlight Milestones

danbugs added this to the Backlog milestone

danbugs modified the milestones: Backlog, Upcoming

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment