Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit tracing strategy #188

Open
ludfjig opened this issue Jan 29, 2025 · 2 comments
Open

Revisit tracing strategy #188

ludfjig opened this issue Jan 29, 2025 · 2 comments
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Milestone

Comments

@ludfjig
Copy link
Contributor

ludfjig commented Jan 29, 2025

The current state of tracing in hyperlight is a bit all over the place. We should have:

  • Less fine grained tracing: Right now many irrelevant small helper functions are being traced. We should consider only covering our APIs
  • Include guest calls in tracing spans
  • Revisit which function parameters should and shouldn't be traced.
  • Revisit tracing log levels
@github-actions github-actions bot added the lifecycle/needs-review The issue has not yet been reviewed. label Jan 29, 2025
@syntactically syntactically added lifecycle/confirmed Bug is verified or proposal seems reasonable and removed lifecycle/needs-review The issue has not yet been reviewed. labels Feb 5, 2025
@danbugs danbugs added this to the Backlog milestone Mar 4, 2025
@simongdavies
Copy link
Contributor

I suggest that we only place trace attributes on pub functions, that should reduce the overhead/noise

@danbugs
Copy link
Contributor

danbugs commented Mar 19, 2025

Related to #318

@danbugs danbugs modified the milestones: Backlog, Upcoming Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/confirmed Bug is verified or proposal seems reasonable
Projects
Status: No status
Development

No branches or pull requests

4 participants