Skip to content

Commit b9d4b79

Browse files
committed
Updating benchmark testing to support mshv3 features gates and driver
Signed-off-by: Mark Rossetti <[email protected]>
1 parent cfc7860 commit b9d4b79

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

.github/workflows/Benchmarks.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@ jobs:
1717
strategy:
1818
fail-fast: true
1919
matrix:
20-
hypervisor: [hyperv, mshv, kvm] # hyperv is windows, mshv and kvm are linux
20+
hypervisor: [hyperv, mshv, mshv3, kvm] # hyperv is windows, mshv and kvm are linux
2121
cpu: [amd, intel]
2222
config: [release] # don't want to benchmark debug-builds
2323

24-
runs-on: ${{ fromJson(format('["self-hosted", "{0}", "X64", "1ES.Pool=hld-{1}-{2}"]', matrix.hypervisor == 'hyperv' && 'Windows' || 'Linux', matrix.hypervisor == 'hyperv' && 'win2022' || matrix.hypervisor, matrix.cpu)) }}
24+
runs-on: ${{ fromJson(format('["self-hosted", "{0}", "X64", "1ES.Pool=hld-{1}-{2}"]', matrix.hypervisor == 'hyperv' && 'Windows' || 'Linux', matrix.hypervisor == 'hyperv' && 'win2022' || matrix.hypervisor == 'mshv3' && 'azlinux3-mshv' || matrix.hypervisor, matrix.cpu)) }}
2525

2626
steps:
2727
### Setup ###
@@ -67,7 +67,7 @@ jobs:
6767
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6868

6969
- name: Run Benchmarks
70-
run: just bench-ci main release
70+
run: just bench-ci main release ${{ matrix.hypervisor == 'mshv3' && 'mshv3' || ''}}
7171

7272
- uses: actions/upload-artifact@v4
7373
with:

.github/workflows/dep_rust.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,5 +118,5 @@ jobs:
118118

119119
- name: Run benchmarks
120120
run: |
121-
just bench-ci main ${{ matrix.config }}
121+
just bench-ci main ${{ matrix.config }} ${{ matrix.hypervisor == 'mshv3' && 'mshv3' || ''}}
122122
if: ${{ matrix.config == 'release' }}

Justfile

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -174,11 +174,11 @@ bench-download os hypervisor cpu tag="":
174174
tar -zxvf target/benchmarks_{{ os }}_{{ hypervisor }}_{{ cpu }}.tar.gz -C target/criterion/ --strip-components=1
175175

176176
# Warning: compares to and then OVERWRITES the given baseline
177-
bench-ci baseline target=default-target:
178-
cargo bench --profile={{ if target == "debug" { "dev" } else { target } }} -- --verbose --save-baseline {{ baseline }}
177+
bench-ci baseline target=default-target features="":
178+
cargo bench --profile={{ if target == "debug" { "dev" } else { target } }} {{ if features =="" {''} else { "--features " + features } }} -- --verbose --save-baseline {{ baseline }}
179179

180-
bench target=default-target:
181-
cargo bench --profile={{ if target == "debug" { "dev" } else { target } }} -- --verbose
180+
bench target=default-target features="":
181+
cargo bench --profile={{ if target == "debug" { "dev" } else { target } }} {{ if features =="" {''} else { "--features " + features } }} -- --verbose
182182

183183
# FUZZING
184184
fuzz:

0 commit comments

Comments
 (0)